New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802300 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK failure in IsFixedArrayWithProgressBar(obj) || obj->IsJSObject() || obj->IsString() in incr

Project Member Reported by ClusterFuzz, Jan 16 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6249957991645184

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  IsFixedArrayWithProgressBar(obj) || obj->IsJSObject() || obj->IsString() in incr
  v8::platform::PrintStackTrace
  v8::internal::IncrementalMarking::VisitObject
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=50557:50558

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6249957991645184

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 16 2018

Labels: Test-Predator-Auto-Owner
Owner: adamk@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/49898aad76cb2101e599078eb8d4e55836969484 (Remove always-true --harmony-async-iteration runtime flag).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 2 by adamk@chromium.org, Jan 16 2018

Status: Started (was: Assigned)

Comment 3 by adamk@chromium.org, Jan 16 2018

Cc: adamk@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>GC
Labels: -Test-Predator-Auto-Owner Test-Predator-Wrong-CLs
Owner: ----
Status: Untriaged (was: Started)
My change only removed a runtime flag that was always-on, which seems to have perturbed some existing bug in incremental marking. I don't know enough about incremental marking to reasonably evaluate this report, though.
Blocking: v8:6972
Blocking: -v8:6972
This also reproduces on linux, for different values of --gc-interval. I will start a local bisect.
Owner: ishell@chromium.org
Status: Assigned (was: Untriaged)
Bisects to 7cdfb6df23883f788ea691f02c70f256f8375f4f ([ic] Introduce proper StoreGlobalIC dispatcher.).
Reproduces with --gc-interval=130. Before that CL, does not reproduce with any interval between 0 and 1000 (tested all multiples of 10).
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 17 2018

Labels: Pri-1
Labels: Security_Impact-Head M-65
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 21 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Started (was: Assigned)
Cc: ishell@chromium.org
Owner: u...@chromium.org
Status: Assigned (was: Started)
It looks like the check which is failing is in sync with recent deoptimizer changes. Assigning to Ulan.

Comment 13 by u...@chromium.org, Jan 22 2018

Labels: -Security_Impact-Head -Security_Severity-High
The DCHECK is not precise and has to be fixed.

Comment 14 by u...@chromium.org, Jan 22 2018

Labels: -ReleaseBlock-Stable
Labels: -Type-Bug-Security Type-Bug
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6551719630c85d91f93378921f67a5c12d5d2328

commit 6551719630c85d91f93378921f67a5c12d5d2328
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Fri Jan 26 13:29:58 2018

[heap] Fix assertion in IncrementalMarking::VisitObject.

Bug:  chromium:802300 
Change-Id: I187f72eda80ae7d6a705361bdd36e79196f51293
Reviewed-on: https://chromium-review.googlesource.com/888743
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50897}
[modify] https://crrev.com/6551719630c85d91f93378921f67a5c12d5d2328/src/heap/incremental-marking.cc

Project Member

Comment 17 by ClusterFuzz, Jan 30 2018

Status: WontFix (was: Assigned)
ClusterFuzz testcase 6249957991645184 is flaky and no longer crashes, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 18 by u...@chromium.org, Jan 31 2018

Labels: ClusterFuzz-Wrong
Status: Fixed (was: WontFix)
It was fixed.
Project Member

Comment 19 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 20 by sheriffbot@chromium.org, May 9 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment