New issue
Advanced search Search tips

Issue 802291 link

Starred by 1 user
Status: Fixed
Owner:
mustaq@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 802294



Sign in to add a comment

UserActivationV2 regression with timer behavior

Project Member Reported by mustaq@chromium.org, Jan 16 2018 
Currently we don't allow UserGestureToken propagation through setTimeout calls when:
- setTimeout call depth is more than 2, or
- the timeout is more than 1 sec.

UserActivationV2 allows both of these cases because it doesn't need token forwarding (and hence free from possible token duplication).

These two layout tests fail with V2 because of this:
fast/events/popup-blocking-timers4.html [timer depth]
fast/events/popup-blocking-timers6.html [1sec expiry]

Comment 1 by mustaq@chromium.org, Jan 16 2018

Blocking: 802294
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d44bd4160d2e888332ebba3d9571589a166b7fa

commit 9d44bd4160d2e888332ebba3d9571589a166b7fa
Author: Mustaq Ahmed <mustaq@google.com>
Date: Mon Jun 18 14:14:55 2018

[UAv2] Add a virtual suite for fast/events/

Bug:  802291 
Change-Id: I2b8e7ee5cd61cc31e07bd7d2ed6da69a43743b80
Reviewed-on: https://chromium-review.googlesource.com/1097796
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567992}
[modify] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers4.html
[modify] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/fast/events/popup-blocking-timers6.html
[modify] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/fast/events/resources/open-window-from-another-frame-otherFrame.html
[add] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fast/events/README.txt
[add] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fast/events/open-window-from-another-frame-expected.txt
[add] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fast/events/popup-blocking-timers4-expected.txt
[add] https://crrev.com/9d44bd4160d2e888332ebba3d9571589a166b7fa/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fast/events/popup-blocking-timers6-expected.txt

Comment 3 by mustaq@chromium.org, Jun 18 2018

Status: Fixed (was: Assigned)

Comment 5 by treib@chromium.org, Jun 18 2018 

Looks like this is bug 652536, and just missing a new expectation. I'll add it.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e52df8ee2ff00b77def7f87b221539ba98f0b00

commit 2e52df8ee2ff00b77def7f87b221539ba98f0b00
Author: Marc Treib <treib@chromium.org>
Date: Mon Jun 18 16:48:42 2018

Add expectation for virtual/user-activation-v2/fast/events/mouse-cursor-change-after-image-load.html

TBR=mustaq@chromium.org
NOTRY=true

Bug: 652536,  802291 
Change-Id: I60a020661cc0027b1f0db7f9e1f232b1f1a20976
Reviewed-on: https://chromium-review.googlesource.com/1104693
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568037}
[modify] https://crrev.com/2e52df8ee2ff00b77def7f87b221539ba98f0b00/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by treib@chromium.org, Jun 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment