New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802290 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3%-175% regression in webrtc_perf_tests at 21601:21601

Project Member Reported by philipel@chromium.org, Jan 16 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 16 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=802290

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=28b37e25084ade74b7a07ca1737be8b8be1a259561d3d473a7eaed93d03bb886


Bot(s) for this bug's original alert(s):

webrtc-android-tests-nexus4-lollipop
webrtc-android-tests-nexus9
webrtc-mac-large-tests
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/db9e9d5486c40f4b78513fedc79b9b22ad3e5751

commit db9e9d5486c40f4b78513fedc79b9b22ad3e5751
Author: Erik Språng <sprang@webrtc.org>
Date: Mon Jan 22 21:15:29 2018

Make screenshare_layers frame dropper less aggressive

Try to use frame timestamps first if they look reasonable, otherwise
use realtime clock.
Also, lower limit from 90% of target to 85%.

Bug: webrtc:4172, chromium:802290
Change-Id: Iad489be7c7cf637345be4795e5089936ab9fab07
Reviewed-on: https://webrtc-review.googlesource.com/41041
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21729}
[modify] https://crrev.com/db9e9d5486c40f4b78513fedc79b9b22ad3e5751/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/db9e9d5486c40f4b78513fedc79b9b22ad3e5751/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2018

Labels: merge-merged-65
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8faa0889cccd94d0f2cf57f7f26b76b22a51315e

commit 8faa0889cccd94d0f2cf57f7f26b76b22a51315e
Author: Erik Språng <sprang@webrtc.org>
Date: Fri Feb 02 14:26:17 2018

Merge to M65: Make screenshare_layers frame dropper less aggressive

Try to use frame timestamps first if they look reasonable, otherwise
use realtime clock.
Also, lower limit from 90% of target to 85%.

Original Change Id: Iad489be7c7cf637345be4795e5089936ab9fab07
Originally Reviewed On: https://webrtc-review.googlesource.com/41041

Bug: webrtc:4172, chromium:802290
Change-Id: Iad489be7c7cf637345be4795e5089936ab9fab07
Reviewed-on: https://webrtc-review.googlesource.com/47440
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/branch-heads/65@{#9}
Cr-Branched-From: 3ac67a736bb200ecf7c116a88b2f8d5c542973c8-refs/heads/master@{#21637}
[modify] https://crrev.com/8faa0889cccd94d0f2cf57f7f26b76b22a51315e/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/8faa0889cccd94d0f2cf57f7f26b76b22a51315e/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Sign in to add a comment