New issue
Advanced search Search tips

Issue 802286 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 802294



Sign in to add a comment

UserActivationV2 regression in autoplay "Back Forward List"

Project Member Reported by mustaq@chromium.org, Jan 16 2018

Issue description

When we enable UserActivationV2, three autoplay layout tests fail with similar regressions in the "Back Forward List".

E.g. for http/tests/media/autoplay/document-user-activation-navigation-click.html, the list contains these two entries if UserActivationV2 is enabled:
  http://127.0.0.1:8000/media/autoplay/document-user-activation-navigation-click.html
  curr->  http://127.0.0.1:8000/media/autoplay/resources/test-autoplay.html
but only the second entry otherwise.

Shouldn't we always have the two entries?

The same happens with the tests:
document-user-activation-navigation-keypress.html
document-user-activation-navigation-tap.html

 

Comment 1 by mustaq@chromium.org, Jan 16 2018

Blocking: 696617

Comment 2 by mustaq@chromium.org, Jan 16 2018

Components: Blink>Input
Labels: -OS-Linux

Comment 3 by mustaq@chromium.org, Jan 16 2018

Blocking: -696617 802294
Components: Blink>Media>Autoplay
beccahughes@ has a CL improving these tests. I wonder if it may fix this.

Comment 6 by mustaq@chromium.org, Jun 19 2018

Status: Started (was: Assigned)
To unblock UAv2, I will create a virtual test suite with modified expectations.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47023ef21b33501d9cfdc559e97ca183d6808127

commit 47023ef21b33501d9cfdc559e97ca183d6808127
Author: Mustaq Ahmed <mustaq@google.com>
Date: Wed Jun 20 17:00:18 2018

[UAv2] Add a virtual suite for http/tests/media/autoplay/

Bug:  802286 
Change-Id: I618811046ccbda914b5dcc673c62ba4ea4a550eb
Reviewed-on: https://chromium-review.googlesource.com/1106553
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568881}
[modify] https://crrev.com/47023ef21b33501d9cfdc559e97ca183d6808127/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/47023ef21b33501d9cfdc559e97ca183d6808127/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/47023ef21b33501d9cfdc559e97ca183d6808127/third_party/WebKit/LayoutTests/virtual/user-activation-v2/http/tests/media/autoplay/README.txt
[add] https://crrev.com/47023ef21b33501d9cfdc559e97ca183d6808127/third_party/WebKit/LayoutTests/virtual/user-activation-v2/http/tests/media/autoplay/document-user-activation-navigation-click-expected.txt
[add] https://crrev.com/47023ef21b33501d9cfdc559e97ca183d6808127/third_party/WebKit/LayoutTests/virtual/user-activation-v2/http/tests/media/autoplay/document-user-activation-navigation-keypress-expected.txt
[add] https://crrev.com/47023ef21b33501d9cfdc559e97ca183d6808127/third_party/WebKit/LayoutTests/virtual/user-activation-v2/http/tests/media/autoplay/document-user-activation-navigation-tap-expected.txt

Comment 8 by mustaq@chromium.org, Jun 20 2018

Status: Fixed (was: Started)

Sign in to add a comment