[root layer scrolls] PPAPI test failures |
||
Issue descriptionThe following tests fail in some steps on some bots: OutOfProcessPPAPITest.View PPAPINaClNewlibTest.View PPAPINaClPNaClNonSfiTest.View PPAPINaClPNaClTest.View Bot links (and which tests failed on them): https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_asan_rel_ng/521864 https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/76819 https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/58124 (OutOfProcessPPAPITest, PPAPINaClNewlibTest) https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/34722 https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/620275 (OutOfProcessPPAPITest, PPAPINaClNewlibTest, PPAPINaClPNaClNonSfiTest) https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/623932 (OutOfProcessPPAPITest, PPAPINaClNewlibTest, PPAPINaClPNaClTest) The affected test steps are: browser_tests mus_browser_tests network_service_browser_tests site_per_process_browser_tests The tests crash with: BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000053e8bac base::debug::StackTrace::StackTrace() #1 0x000005a56fc2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fc960385cb0 <unknown> #3 0x7fc96043fc5d __poll #4 0x7fc9656cdfe4 <unknown> #5 0x7fc9656ce0ec g_main_context_iteration #6 0x000005413852 base::MessagePumpGlib::Run() #7 0x00000540ea8c base::MessageLoop::Run() #8 0x0000054415a6 base::RunLoop::Run() #9 0x000005a96e73 content::RunMessageLoop() #10 0x000005a68edd content::JavascriptTestObserver::Run() #11 0x0000054cd7af PPAPITestBase::RunTestURL() #12 0x0000054cdb05 PPAPITestBase::RunTestViaHTTP() #13 0x0000029ff84d PPAPINaClNewlibTest_View_Test::RunTestOnMainThread() #14 0x000005a56cd3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c25c904bbc8d12d128112a0bdd2536f653483b7a commit c25c904bbc8d12d128112a0bdd2536f653483b7a Author: David Bokan <bokan@chromium.org> Date: Fri Jan 19 16:39:51 2018 Fix plugin geometry under root-layer-scrolling This patch fixes the plugin rect calculations in WebPluginContainerImpl to be correct when root-layer-scrolling is turned on. Without RLS, "absolute" coordinates are relative to the document origin and so are invariant under scrolling. This method would account for the frame's scroll offset by itself. When RLS is turned on, "absolute" coordinates are relative to the frame rect and so they already account for the frame scroll. TESTING=In runtime_enabled_features.json5, set RootLayerScrolling to `status: "stable"` and run: `browser_tests --gtest_filter=PPAPINaClNewlibTest.View` Bug: 802279 Change-Id: I5360d4a86e8a0688107fe88ba79f26b08a56f968 Reviewed-on: https://chromium-review.googlesource.com/873710 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#530535} [modify] https://crrev.com/c25c904bbc8d12d128112a0bdd2536f653483b7a/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp [modify] https://crrev.com/c25c904bbc8d12d128112a0bdd2536f653483b7a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/c25c904bbc8d12d128112a0bdd2536f653483b7a/third_party/WebKit/Source/core/frame/LocalFrameView.h
,
Jan 19 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bokan@chromium.org
, Jan 17 2018Status: Started (was: Available)