[root layer scrolls] DomTreeExtractionBrowserTest fails |
||
Issue descriptionThis test fails in the headless_browsertests step on two trybots: DomTreeExtractionBrowserTest.RunAsyncTest The affected bots are: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_headless_rel/233159 https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/58124 The output includes: ../../headless/lib/headless_devtools_client_browsertest.cc:1362: Failure Expected equality of these values: expected_dom_nodes Which is: "{\n \"backendNodeId\": 3,\n \"baseURL\": \"http://127.0.0.1/dom_tree_test.html\",\n..." dom_nodes_result Which is: "{\n \"backendNodeId\": 2,\n \"baseURL\": \"http://127.0.0.1/dom_tree_test.html\",\n..." With diff: @@ -1,4 +1,4 @@ { - \"backendNodeId\": 3, + \"backendNodeId\": 2, \"baseURL\": \"http://127.0.0.1/dom_tree_test.html\", \"boundingBox\": { @@ -18,5 +18,5 @@ } { - \"backendNodeId\": 4, + \"backendNodeId\": 3, \"boundingBox\": { \"height\": 600.0, @@ -34,5 +34,5 @@ } { - \"backendNodeId\": 5, + \"backendNodeId\": 4, \"childNodeIndexes\": [ 3, 4, 6, 7, 8 ], \"nodeName\": \"HEAD\", @@ -41,5 +41,5 @@ } ... [ FAILED ] DomTreeExtractionBrowserTest.RunAsyncTest, where TypeParam = and GetParam() = (332 ms)
,
Jan 18 2018
This one just needs a rebaseline to the expectations; the id on each node is decremented since we no longer create a root_content_layer_ in PLC::EnsureRootLayer which consumes an id via DOMNodeIds::IdForNode.
,
Jan 19 2018
After syncing to ToT the test stopped failing for me. Ran a new try job and the test is green on all previously affected bots: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_headless_rel/239694 https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/65026 |
||
►
Sign in to add a comment |
||
Comment 1 by bokan@chromium.org
, Jan 18 2018Status: Started (was: Available)