Issue metadata
Sign in to add a comment
|
-webkit-background-origin accepts the 'text' value |
||||||||||||||||||||||
Issue descriptionTest: https://jsfiddle.net/9gfp98da/ (The 'text' value will be treated the same as 'padding-box'.) Don't know if this is something that was introduced recently, or if it's been like this for a long time (-webkit-background-origin is parsed the same as -webkit-background-clip, which is likely the source of this issue.)
,
Jan 16 2018
Suspecting https://crrev.com/406dacf613a5932419b283111df9849115830cc9
,
Jan 16 2018
Have confirmed my patch is causing this. Will investigate.
,
Jan 17 2018
,
Jan 18 2018
Looks like I accidentally changed the parsing logic for -webkit-background-origin to match -webkit-background-clip instead of -webkit-mask-origin like it should have been. The code has changed a fair bit since my patch, but the fix for this is to rewrite BackgroundOrigin::ParseSingleValue to include the alias branch and disallow text in the alias branch. Note that the unprefixed background-origin behaves correctly.
,
Feb 18 2018
,
Feb 18 2018
I have a WIP patch up that fixes this at https://chromium-review.googlesource.com/c/chromium/src/+/923665, it still needs a layout test. I'm on leave so will be slow on this.
,
Mar 23 2018
,
Apr 11 2018
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65a1361623957de8a5ec62ed44ffda141266c12b commit 65a1361623957de8a5ec62ed44ffda141266c12b Author: Rob Buis <rob.buis@samsung.com> Date: Thu Apr 12 16:01:03 2018 Fix regression allowing text value for -webkit-background-origin Fix regression allowing text value for -webkit-background-origin that was caused by r514365. Code change implemented by Bugs Nash, testcase by Rob Buis. Bug: 802256 Change-Id: I11e2b1b19a374e9f6b9c1091d82882ef526bc63c Reviewed-on: https://chromium-review.googlesource.com/1008102 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550221} [add] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/WebKit/LayoutTests/external/wpt/compat/webkit-background-origin-text-ref.html [add] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/WebKit/LayoutTests/external/wpt/compat/webkit-background-origin-text.html [modify] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc [modify] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/blink/renderer/core/css/properties/css_parsing_utils.h [modify] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/blink/renderer/core/css/properties/longhands/background_clip_custom.cc [modify] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/blink/renderer/core/css/properties/longhands/background_origin_custom.cc
,
Apr 12 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65a1361623957de8a5ec62ed44ffda141266c12b commit 65a1361623957de8a5ec62ed44ffda141266c12b Author: Rob Buis <rob.buis@samsung.com> Date: Thu Apr 12 16:01:03 2018 Fix regression allowing text value for -webkit-background-origin Fix regression allowing text value for -webkit-background-origin that was caused by r514365. Code change implemented by Bugs Nash, testcase by Rob Buis. Bug: 802256 Change-Id: I11e2b1b19a374e9f6b9c1091d82882ef526bc63c Reviewed-on: https://chromium-review.googlesource.com/1008102 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550221} [add] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/WebKit/LayoutTests/external/wpt/compat/webkit-background-origin-text-ref.html [add] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/WebKit/LayoutTests/external/wpt/compat/webkit-background-origin-text.html [modify] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc [modify] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/blink/renderer/core/css/properties/css_parsing_utils.h [modify] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/blink/renderer/core/css/properties/longhands/background_clip_custom.cc [modify] https://crrev.com/65a1361623957de8a5ec62ed44ffda141266c12b/third_party/blink/renderer/core/css/properties/longhands/background_origin_custom.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by futhark@chromium.org
, Jan 16 2018