New issue
Advanced search Search tips

Issue 802254 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

org.chromium.chrome.browser.modaldialog.ModalDialogManagerTest#testShow_UrlBarFocused is flaky

Project Member Reported by alexilin@chromium.org, Jan 16 2018

Issue description

Recent failed build: https://ci.chromium.org/buildbot/chromium.android/Lollipop%20Phone%20Tester/18035

Link to the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.modaldialog.ModalDialogManagerTest#testShow_UrlBarFocused

Stack trace:
java.lang.RuntimeException: Exception occurred while waiting for runnable
	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:81)
	at org.chromium.chrome.browser.modaldialog.ModalDialogManagerTest.testShow_UrlBarFocused(ModalDialogManagerTest.java:244)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:113)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:184)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:41)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:166)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:99)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
Caused by: java.util.concurrent.ExecutionException: java.lang.AssertionError
	at java.util.concurrent.FutureTask.report(FutureTask.java:93)
	at java.util.concurrent.FutureTask.get(FutureTask.java:163)
	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:79)
	... 38 more
Caused by: java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.chromium.chrome.browser.modaldialog.ModalDialogManagerTest.lambda$testShow_UrlBarFocused$2$ModalDialogManagerTest(ModalDialogManagerTest.java:245)
	at org.chromium.chrome.browser.modaldialog.ModalDialogManagerTest$$Lambda$2.run(Unknown Source)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:135)
	at android.app.ActivityThread.main(ActivityThread.java:5254)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b5d513a065b1efda78f7edbab0468973f276efc

commit 8b5d513a065b1efda78f7edbab0468973f276efc
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Tue Jan 16 15:55:18 2018

Disable flaky ModalDialogManagerTest.testShow_UrlBarFocused

TBR=tedchoc@chromium.org,huayinz@chromium.org

Bug: 802254
Change-Id: I474013fb6110d2256a1a18926ac805d24c068cf0
Reviewed-on: https://chromium-review.googlesource.com/868435
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529432}
[modify] https://crrev.com/8b5d513a065b1efda78f7edbab0468973f276efc/chrome/android/javatests/src/org/chromium/chrome/browser/modaldialog/ModalDialogManagerTest.java

Cc: tedc...@chromium.org linds...@chromium.org
Labels: Test-Disabled
Hi Becky,

Can you please review this disabled test? This disable reduces test coverage. How critical is this failure/removal?

Thanks,
Hi Lindsay,

I'll try to fix some of these disabled tests in ModalDialogManagerTest today or tomorrow.

Thanks!
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c83f884f9bbfb0dd68f694743d225c0b6f13349f

commit c83f884f9bbfb0dd68f694743d225c0b6f13349f
Author: Becky Zhou <huayinz@chromium.org>
Date: Mon Jan 29 18:40:22 2018

[TabModal] Fix two flaky tab modal dialog related tests

+ Speculative fix for ModalDialogManagerTest#testShow_UrlBarFocused:
  Wait for url bar focused callback to make sure dialogs are updated.
+ JavascriptTabModalDialogTest#testAlertModalDialogMessageFocus:
  Use landscape mode for test to make sure alert message is long enough.

Bug: 802254, 800377
Change-Id: Ic7549b81aa1ca8900858260f6311772014c7de37
Reviewed-on: https://chromium-review.googlesource.com/887823
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532507}
[modify] https://crrev.com/c83f884f9bbfb0dd68f694743d225c0b6f13349f/chrome/android/javatests/src/org/chromium/chrome/browser/jsdialog/JavascriptTabModalDialogTest.java
[modify] https://crrev.com/c83f884f9bbfb0dd68f694743d225c0b6f13349f/chrome/android/javatests/src/org/chromium/chrome/browser/modaldialog/ModalDialogManagerTest.java

Is this considered fixed now?
Labels: Hotlist-DisableReview
@huayinz ping?

Sign in to add a comment