New issue
Advanced search Search tips

Issue 802242 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Timeout in pdf_cfx_barcode_fuzzer

Project Member Reported by ClusterFuzz, Jan 16 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5238060207046656

Fuzzer: libFuzzer_pdf_cfx_barcode_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_cfx_barcode_fuzzer
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5238060207046656

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

Note: This crash might not be reproducible with the provided testcase. That said, for the past 14 days we've been seeing this crash frequently. If you are unable to reproduce this, please try a speculative fix based on the crash stacktrace in the report. The fix can be verified by looking at the crash statistics in the report, a day after the fix is deployed. We will auto-close the bug if the crash is not seen for 14 days.
 
Project Member

Comment 1 by ClusterFuzz, Jan 16 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Blocking: 62400
Labels: -Pri-1 Pri-2
Owner: rharrison@chromium.org
Status: Assigned (was: Untriaged)
XFA only
Project Member

Comment 3 by ClusterFuzz, Jan 17 2018

Labels: OS-Mac
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/7b77dfc9aafb423e6204dd5433699cfd787147b3

commit 7b77dfc9aafb423e6204dd5433699cfd787147b3
Author: Ryan Harrison <rharrison@chromium.org>
Date: Wed Apr 11 17:55:00 2018

Reserve space to reduce memory operations while encoding barcode

In the test case from the bug, the majority of the time is being spent
resizing Widestring internal buffers, since += is being called in a
tight loop. Since the size of the input being mutated and stored is
known, this CL reserves the space before hand to lower thrashing. This
substantially improves runtime of this test case locally.

BUG= chromium:802242 

Change-Id: I5176dabc94634b4d6bc3e9425fe6469a5bf35a41
Reviewed-on: https://pdfium-review.googlesource.com/30190
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

[modify] https://crrev.com/7b77dfc9aafb423e6204dd5433699cfd787147b3/fxbarcode/pdf417/BC_PDF417HighLevelEncoder.cpp

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b45464bb8cd14b468d28e6cb80cd207441baf5c9

commit b45464bb8cd14b468d28e6cb80cd207441baf5c9
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 12 06:25:13 2018

Roll src/third_party/pdfium/ 6bebd2e3c..87b67f842 (8 commits)

https://pdfium.googlesource.com/pdfium.git/+log/6bebd2e3cfb7..87b67f842fe5

$ git log 6bebd2e3c..87b67f842 --date=short --no-merges --format='%ad %ae %s'
2018-04-11 tsepez Remove CFX_DIBAttribute::m_strAuthor
2018-04-11 hnakashima Fix crash when ColorSpace references itself directly.
2018-04-11 tsepez Fix issues with PDFium third_party/base/span.h
2018-04-11 tsepez Remove use of GetBuffer()/ReleaseBuffer() when c_str() is sufficient.
2018-04-11 tsepez Make cxfa_fmlexer.cpp resilient to null strings
2018-04-11 tsepez Fix trailing whitespace handling in CPDF_StreamParser::ReadInlineStream()
2018-04-11 rharrison Reserve space to reduce memory operations while encoding barcode
2018-04-11 rharrison Add documentation about Valgrind LLD workaround

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:828206 , chromium:831498 , chromium:802242 , chromium:830706 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7134510b37a0aab373bdff663020825afe63436f
Reviewed-on: https://chromium-review.googlesource.com/1008962
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550047}
[modify] https://crrev.com/b45464bb8cd14b468d28e6cb80cd207441baf5c9/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c2ee16327d768f20cde0957e091856a4e646c30

commit 2c2ee16327d768f20cde0957e091856a4e646c30
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 12 22:04:21 2018

Roll src/third_party/pdfium/ e6d4559a1..9e625db79 (12 commits)

https://pdfium.googlesource.com/pdfium.git/+log/e6d4559a1b6c..9e625db795ca

$ git log e6d4559a1..9e625db79 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 thestig Slightly simplify CPDF_Color::SetColorSpace().
2018-04-12 tsepez Return pdfium::span<char> from ByteString::GetBuffer().
2018-04-12 tsepez Return pdfium::span<wchar_t> from WideString::GetBuffer().
2018-04-12 rharrison Tidy up types in CBC_PDF417HighLevelEncoder
2018-04-12 rharrison Fail decode if continuing to get insufficient size error
2018-04-12 thestig Make the input data to CPDF_ColorSpace::GetRGB() const.
2018-04-12 thestig Change CPDF{XFA}_Page::PageToDevice() to take a CFX_PointF.
2018-04-12 thestig Add return value to FPDF_DeviceToPage().
2018-04-12 thestig Add CPDF_Page::DeviceToPage() / PageToDevice().
2018-04-12 thestig Change some CPDFXFA_Page methods to take rects and points.
2018-04-12 thestig Change GetDisplayMatrix methods to take FX_RECT.
2018-04-12 thestig Make CFX_Font take FX_RECT out params by pointer.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:802242 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iccdcc7755116bfb7f322ba62beb28cbb11f61bc1
Reviewed-on: https://chromium-review.googlesource.com/1011127
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550379}
[modify] https://crrev.com/2c2ee16327d768f20cde0957e091856a4e646c30/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c2ee16327d768f20cde0957e091856a4e646c30

commit 2c2ee16327d768f20cde0957e091856a4e646c30
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 12 22:04:21 2018

Roll src/third_party/pdfium/ e6d4559a1..9e625db79 (12 commits)

https://pdfium.googlesource.com/pdfium.git/+log/e6d4559a1b6c..9e625db795ca

$ git log e6d4559a1..9e625db79 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 thestig Slightly simplify CPDF_Color::SetColorSpace().
2018-04-12 tsepez Return pdfium::span<char> from ByteString::GetBuffer().
2018-04-12 tsepez Return pdfium::span<wchar_t> from WideString::GetBuffer().
2018-04-12 rharrison Tidy up types in CBC_PDF417HighLevelEncoder
2018-04-12 rharrison Fail decode if continuing to get insufficient size error
2018-04-12 thestig Make the input data to CPDF_ColorSpace::GetRGB() const.
2018-04-12 thestig Change CPDF{XFA}_Page::PageToDevice() to take a CFX_PointF.
2018-04-12 thestig Add return value to FPDF_DeviceToPage().
2018-04-12 thestig Add CPDF_Page::DeviceToPage() / PageToDevice().
2018-04-12 thestig Change some CPDFXFA_Page methods to take rects and points.
2018-04-12 thestig Change GetDisplayMatrix methods to take FX_RECT.
2018-04-12 thestig Make CFX_Font take FX_RECT out params by pointer.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:802242 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iccdcc7755116bfb7f322ba62beb28cbb11f61bc1
Reviewed-on: https://chromium-review.googlesource.com/1011127
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550379}
[modify] https://crrev.com/2c2ee16327d768f20cde0957e091856a4e646c30/DEPS

Sign in to add a comment