Issue metadata
Sign in to add a comment
|
Regression: Unable to see 'Removed' text for removed file on download shelf.
Reported by
db...@etouch.net,
Jan 16 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3322.3 Revision 8758ca55b13d4f2082b2ed9269fce8f37f37c577-refs/branch-heads/3322@{#6} OS: Mac(10.12.6,10.13.1,10.13.3) Pre-condition: Enabled 'Enable Material Design download shelf' flag from chrome://flags What steps will reproduce the problem? (1) Launch chrome, press Ctrl+S to save to page(Download bar appears). (2) Delete the downloaded page from system and click on page from download shelf. (3) Observe on download shelf. Actual: Unable to see 'Removed' text for removed file on download shelf. Expected: 'Removed' text should seen for removed file on download shelf. This is a regression issue, broken in 'M65', below is bisect info: Good Build: 64.0.3240.0(508935) Bad Build: 64.0.3241.0(509211) You are probably looking for a change made after 509140 (known good), but no later than 509141 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/ec3d9ebab41efcfdcea80a45d639848daf1b2161..8e416ac9c6cef242f3368c9ac65b0611fbb91995 Suspect : https://chromium.googlesource.com/chromium/src/+/8e416ac9c6cef242f3368c9ac65b0611fbb91995 Note: 1.Issue is not seen on Windows(7,8,10) and Linux(14.04 LTS) OS. 2.Issue is also seen on M64 Beta(# 64.0.3282.85) and M65 Dev(# 65.0.3315.3)
,
Jan 23 2018
Mac triage: This isn't Pri-1, but this does need to be done before MD downloads launches.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94cbed133d895c7259a798c871549e7a8539fade commit 94cbed133d895c7259a798c871549e7a8539fade Author: Sidney San Martín <sdy@chromium.org> Date: Wed Jan 24 19:44:48 2018 MD downloads: support showing status text after a download has finished. This fixes "Removed" not appearing if you click a download after deleting its file from disk. Bug: 802232 Change-Id: Ia131bda2ef5968eaeb40005132dada4fe070ed58 Reviewed-on: https://chromium-review.googlesource.com/883727 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531648} [modify] https://crrev.com/94cbed133d895c7259a798c871549e7a8539fade/chrome/browser/ui/cocoa/download/md_download_item_view.mm
,
Jan 24 2018
,
Jan 25 2018
Just to Update: Rechecked above issue using latest Canary Build #66.0.3331.0 on Mac(10.12.6,10.13.1,10.13.3) and it seems to be fixed and working as intended. Kindly review attached screencast.
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01c990aaf83c23f8f3d5bd4f899de25efa37da66 commit 01c990aaf83c23f8f3d5bd4f899de25efa37da66 Author: Sidney San Martín <sdy@chromium.org> Date: Thu Jan 25 20:13:58 2018 MD downloads: support showing status text after a download has finished. This fixes "Removed" not appearing if you click a download after deleting its file from disk. TBR=sdy@chromium.org (cherry picked from commit 94cbed133d895c7259a798c871549e7a8539fade) Bug: 802232 Change-Id: Ia131bda2ef5968eaeb40005132dada4fe070ed58 Reviewed-on: https://chromium-review.googlesource.com/883727 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531648} Reviewed-on: https://chromium-review.googlesource.com/887384 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#98} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/01c990aaf83c23f8f3d5bd4f899de25efa37da66/chrome/browser/ui/cocoa/download/md_download_item_view.mm
,
Jan 25 2018
Thanks for verifying!
,
Jan 30 2018
Just to Update: Rechecked above issue using latest Dev Build #65.0.3325.31 on Mac(10.12.6,10.13.1,10.13.3) and it seems to be fixed and working as intended. Kindly review attached screencast.
,
Feb 2 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sdy@chromium.org
, Jan 16 2018