New issue
Advanced search Search tips

Issue 802230 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Cloud import always shows "1 new file found" even when multiple files detected

Project Member Reported by yamaguchi@chromium.org, Jan 16 2018

Issue description

This was originally reported in  Issue 677104 .

Chrome Version: 65.0.3323.0

Steps To Reproduce:
(1) Prepare 2+ new image (.jpg) files in /DCIM folder in an SD card (or a USB drive)
(2) Plug the media to a device. See the Files app opens the /DCIM folder automatically.
(3) Wait a few seconds. See the Cloud Import message pops up.

Expected Result:
"2 new photos found"

Actual Result:
"1 new photo found"
 
Status: Started (was: Available)
It actually backs up all the files when clicking the BACK UP button.
Only the window message appears wrong.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecfb92e6772d21feb14ddd0d56b7d7665ee36ffb

commit ecfb92e6772d21feb14ddd0d56b7d7665ee36ffb
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Jan 23 06:06:36 2018

Show correct number of detected files in the Cloud Import popup.

The messages were originally introduced by:
https://chromium-review.googlesource.com/c/chromium/src/+/734927

Bug:  802230 
Test: manually verified for 1 files and 2+ files
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8e953a02aa61c0919e1bb3c0cbb29b3a20bb27f1
Reviewed-on: https://chromium-review.googlesource.com/868190
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531165}
[modify] https://crrev.com/ecfb92e6772d21feb14ddd0d56b7d7665ee36ffb/ui/file_manager/file_manager/foreground/js/import_controller.js

Labels: Merge-Request-65
I'm requesting merge because this is a regression by the upcoming change.
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 26 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6ef9f4ef8ff6daab848ba1e93e815a48c8fc770

commit a6ef9f4ef8ff6daab848ba1e93e815a48c8fc770
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Jan 26 14:51:20 2018

Show correct number of detected files in the Cloud Import popup.

The messages were originally introduced by:
https://chromium-review.googlesource.com/c/chromium/src/+/734927

Bug:  802230 
Test: manually verified for 1 files and 2+ files
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8e953a02aa61c0919e1bb3c0cbb29b3a20bb27f1
Reviewed-on: https://chromium-review.googlesource.com/868190
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531165}(cherry picked from commit ecfb92e6772d21feb14ddd0d56b7d7665ee36ffb)
Reviewed-on: https://chromium-review.googlesource.com/889238
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#110}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/a6ef9f4ef8ff6daab848ba1e93e815a48c8fc770/ui/file_manager/file_manager/foreground/js/import_controller.js

Status: Fixed (was: Started)

Sign in to add a comment