New issue
Advanced search Search tips

Issue 802222 link

Starred by 1 user
Status: Fixed
Owner:
kojii@chromium.org
Closed: Jan 2018
Cc:
jonr...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Compile error with MSVC in LayoutText::DebugRect()

Project Member Reported by mstensho@chromium.org, Jan 16 2018 
See https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/1977

The code has a range-based for-loop with an unconditional break in the first iteration.

Comment 1 by jonr...@chromium.org, Jan 16 2018

Cc: jonr...@chromium.org
Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)
This was caused by https://chromium-review.googlesource.com/c/chromium/src/+/864962

I'm landing a revert

Comment 2 by jonr...@chromium.org, Jan 16 2018

Labels: -Sheriff-Chromium

Comment 3 by mstensho@chromium.org, Jan 16 2018 

https://chromium-review.googlesource.com/c/chromium/src/+/867912 fixes this, but it has a merge conflict now. Then again, I'm pretty sure you'll get the same problem with a revert.

Comment 4 by jonr...@chromium.org, Jan 16 2018 

Oh I didn't see your patch to fix it. Want me to remove my patch and let you land yours with merge fix?

Comment 5 by mstensho@chromium.org, Jan 16 2018 

Sure, if you can give me an hour or so. Still AFK for some time.

Comment 6 by jonr...@chromium.org, Jan 16 2018 

It looks like the revert made it in without merge conflict. So no rush.

Comment 7 by kojii@chromium.org, Jan 24 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment