New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802219 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression: Unwanted grey focus is seen when clicked on the disabled options in Files App

Project Member Reported by kebalaji@chromium.org, Jan 16 2018

Issue description

Chrome Version:  65.0.3322.0/10312.0.0 dev channel Daisy,Candy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign-in to user>> Open Files App
(2)Add any folder>> Right click and Zip the file
(3)Open the zipped file and Right click on the folder >> Click on any disabled option and observe(Refer video)

Actual: Unwanted grey focus is seen when clicked on the disabled options
Expected: No such focus should be seen
 
This is Non-Regression issue seen from M-62

Note: 1.Issue is seen on M-63 and M-64 also
      2. Issue is not seen on Windows and Linux

@fukino: Please confirm the issue
 
ActualDisabledbuttonFocus.webm
1.7 MB View Download

Comment 1 by fukino@chromium.org, Jan 16 2018

Cc: yamaguchi@chromium.org fukino@chromium.org
Labels: -Pri-2 -M-65 Pri-3
Owner: ----
Status: Available (was: Assigned)
I agree that disabled buttons should not have feedback on clicks, considering the default behavior of paper-button.

However, this issue does not seem time critical, so let me lower the priority.
Labels: Inhouse-HYD-Reported

Comment 3 by sashab@chromium.org, Feb 22 2018

Labels: CrOS-FilesApp-Zip

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Zip CrOSFilesFeature-Zip
Labels: Files-Fixit-2018
Owner: sa...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f4f61a89e2c6dab0de3097fb4c94220307ea080

commit 0f4f61a89e2c6dab0de3097fb4c94220307ea080
Author: Sam McNally <sammc@chromium.org>
Date: Wed Nov 21 04:59:42 2018

Set pointer-events: none on disabled menu items to prevent ripples.

Bug:  802219 
Change-Id: Id442745aebf4f71e0f4fa60510bea8b70a28d2d2
Reviewed-on: https://chromium-review.googlesource.com/c/1345713
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609917}
[modify] https://crrev.com/0f4f61a89e2c6dab0de3097fb4c94220307ea080/ui/file_manager/file_manager/foreground/css/common.css

Status: Fixed (was: Assigned)
Labels: -CrOSFilesFeature-Zip CrOSFilesCategory-UI

Sign in to add a comment