New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802218 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression:Captured photo appears at preview even after picture gets deleted

Project Member Reported by rkalavakuntla@chromium.org, Jan 16 2018

Issue description

Chrome Version:65.0.3322.0/10312.0.0 dev channel Daisy,Candy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign into user ->open chrome://settings/changePicture page and Click to'Take Photo'
(2)Now continuously multiple click on 'Take photo' button near Camera and Observe(kindly refer video)

Actual: Captured photo appears at preview even after picture gets deleted
Expected: Instead, it shouldn't appear 

This is a Non-Regression issue seen from M-61

Note:Issue is not seen in Linux,Windows OS 

@reveman: Please confirm the issue.
 
actual.mp4
6.1 MB View Download
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e474e9655a969b56c98c1d884132196a6d30e00f

commit e474e9655a969b56c98c1d884132196a6d30e00f
Author: David Reveman <reveman@chromium.org>
Date: Sat Jan 20 00:19:53 2018

Change Picture: Fix image discarding race.

This prevents the old image from being discarded until it has
been processed by the browser. It was possible to discard the
image before receiving the ack from the browser without this.
The result was a confusing UX, where the image had been
discarded, but was still appeared in the picture list.

Bug:  802218 
Test: manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d9006361919a4a11edd515929384131427e3b73
Reviewed-on: https://chromium-review.googlesource.com/874799
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530681}
[modify] https://crrev.com/e474e9655a969b56c98c1d884132196a6d30e00f/chrome/browser/resources/settings/people_page/change_picture.js
[modify] https://crrev.com/e474e9655a969b56c98c1d884132196a6d30e00f/chrome/browser/resources/settings/people_page/change_picture_browser_proxy.js

Status: Fixed (was: Started)
Labels: Inhouse-HYD-Reported

Sign in to add a comment