New issue
Advanced search Search tips

Issue 802183 link

Starred by 2 users
Status: Duplicate
Owner:
mdjones@chromium.org
Closed: Mar 2018
Cc:
yus...@chromium.org
tedc...@chromium.org
mdjones@chromium.org
dtrainor@chromium.org
linds...@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

org.chromium.chrome.browser.TabsTest#testToolbarSwipePrevTab is flaky

Project Member Reported by alexilin@chromium.org, Jan 16 2018 
Recent builder failure: https://ci.chromium.org/buildbot/chromium.android/KitKat%20Phone%20Tester%20(rel)/2339

Flakiness dashboard shows that this test rarely passes at the first run on Kitkat Phone Testers and on Lollipop Phone Tester. Due to @RetryOnFailure it often passes at the second or at the third run. 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.TabsTest%23testToolbarSwipePrevTab
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11d0b0718f58885d354b39c858f3ef42aad6f906

commit 11d0b0718f58885d354b39c858f3ef42aad6f906
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Tue Jan 16 11:57:57 2018

Disable flaky TabsTest.testToolbarSwipePrevTab test

TBR=dtrainor@chromium.org,yolandyan@chromium.org

Bug:  802183 
Change-Id: Ic286dcf5efffc53c5513e85263b0aca0be84ed1b
Reviewed-on: https://chromium-review.googlesource.com/866844
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529402}
[modify] https://crrev.com/11d0b0718f58885d354b39c858f3ef42aad6f906/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Comment 2 by linds...@chromium.org, Jan 23 2018

Cc: linds...@chromium.org baxley@chromium.org dtrainor@chromium.org
Labels: Test-Disabled
Hi Yoland,

Can you please review this disabled test? This disable reduces test coverage. How critical is this failure/removal?

Thanks,

Comment 3 by linds...@chromium.org, Jan 30 2018 

@Baxley can you please ask Yoland to take a look?

Comment 4 by yolandyan@chromium.org, Jan 30 2018 

#re:2 Sorry! this went over the head of my inbox last week, will take a look today

Comment 5 by linds...@chromium.org, Mar 20 2018

Labels: Hotlist-DisableReview
Owner: jbudorick@chromium.org
@jbudorick, who is the right owner for this now?

Comment 6 by jbudorick@chromium.org, Mar 20 2018

Cc: -baxley@chromium.org jbudorick@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
I'm not sure, nor am I sure why Yoland was assigned other than JUnit4 migration.

Going to try to get this into the clank bug triage queue for assistance...

Comment 7 by cmasso@google.com, Mar 21 2018

Components: Tests>Flaky

Comment 8 by cmasso@google.com, Mar 21 2018

Components: UI>Browser>Mobile>CompositedUI

Comment 9 by yus...@chromium.org, Mar 23 2018

Cc: mdjones@chromium.org yus...@chromium.org
Status: Available (was: Untriaged)

Comment 10 by linds...@chromium.org, Mar 26 2018

Cc: tedc...@chromium.org

Comment 11 by tedc...@chromium.org, Mar 27 2018

Owner: mdjones@chromium.org
Status: Assigned (was: Available)
Assigning to mdjones@ to triage.  I would suspect our logic in TabsTest#performToolbarSideSwipe is off for certain scenarios.

Seems like we could add some additional logging for this as well.

Comment 12 by mdjones@chromium.org, Mar 27 2018

Mergedinto: 813584
Status: Duplicate (was: Assigned)
►

Sign in to add a comment