New issue
Advanced search Search tips

Issue 802182 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools WebSocket "Frames" tab should be called "Messages"

Project Member Reported by ricea@chromium.org, Jan 16 2018

Issue description

Ever since switching to the "new" WebSocket implementation in 2014, DevTools has been displaying messages rather than frames in the "Frames" tab. It's probably about time we changed the name of the tab.

It would also be good to update the various references in the code to match, for example changing probe::didReceiveWebSocketFrame() to probe::didReceiveWebSocketMessage(). There is a confusing comment in DocumentWebSocketChannel.cpp which says

"""
  // FIXME: Change the inspector API to show the entire message instead
  // of individual frames.
"""

Background: the WebSocket implementation refragments messages internally, so the frame boundaries seen in Blink do not reflect the frame boundaries originally received over the network from the server. As such, it is not useful or meaningful to display them to developers. The DevTools UI dates back to the old implementation, which did preserve frame boundaries.
 

Comment 1 by kozy@chromium.org, Jan 16 2018

Owner: eostroukhov@chromium.org
Status: Assigned (was: Untriaged)
Owner: jarhar@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98

commit 595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98
Author: Joey Arhar <jarhar@chromium.org>
Date: Fri Nov 30 20:27:57 2018

[DevTools] Correct WebSocket Frames to be Messages

Bug:  802182 
Change-Id: I01b45373ab5fe21bf2513cd1ea9e7f2e90d9820f
Reviewed-on: https://chromium-review.googlesource.com/c/1356135
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612761}
[modify] https://crrev.com/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98/third_party/blink/renderer/core/probe/core_probes.json5
[modify] https://crrev.com/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98/third_party/blink/renderer/core/probe/core_probes.pidl
[modify] https://crrev.com/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98/third_party/blink/renderer/devtools/front_end/network/NetworkItemView.js
[modify] https://crrev.com/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98/third_party/blink/renderer/devtools/front_end/network/ResourceWebSocketFrameView.js
[modify] https://crrev.com/595fe3e4e2b1893fcbcd4469f3b86dfc328f8f98/third_party/blink/renderer/modules/websockets/websocket_channel_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment