This code is in ios/web and should also be moved to ios/chrome as this is Chrome specific.
Just realized that shared code should be moved to //components, that's where autofill_controller.js lives.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbef79b02675ced6bb79345dd5abffb0125689e0 commit bbef79b02675ced6bb79345dd5abffb0125689e0 Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Feb 16 13:53:25 2018 Lint and format javascript. Running glint and clang-format on JavaScript files. Bug: 487804, 802170 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic13a1a141b74b761b83d5aee20c0f4bff384b57b Reviewed-on: https://chromium-review.googlesource.com/919263 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537295} [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/components/autofill/ios/browser/resources/autofill_controller.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/components/autofill/ios/browser/resources/suggestion_controller.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/chrome/browser/passwords/BUILD.gn [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/chrome/browser/passwords/resources/password_controller.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/chrome/browser/web/resources/chrome_bundle.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/all_frames_web_bundle.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/base.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/common.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/console.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/context_menu.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/error.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/form.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/legacy.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/legacy_navigation.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/main_frame_web_bundle.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/message.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/navigation.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/plugin_placeholder.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/post_request.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/scroll_workaround.js [modify] https://crrev.com/bbef79b02675ced6bb79345dd5abffb0125689e0/ios/web/web_state/js/resources/window_id.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075 commit fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075 Author: Olivier Robin <olivierrobin@chromium.org> Date: Wed Feb 21 13:36:21 2018 Extract form and fill logic from common.js This methods should not be in common.js as they are only used by autofill and password. Bug: 802170 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7df5b636b0092adb44b3db7e7d45a2b58eab339c Reviewed-on: https://chromium-review.googlesource.com/921242 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#538084} [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/components/autofill/ios/browser/resources/autofill_controller.js [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/components/autofill/ios/browser/resources/suggestion_controller.js [add] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/components/autofill/ios/fill/resources/fill.js [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/chrome/browser/passwords/BUILD.gn [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/chrome/browser/passwords/password_controller_js_unittest.mm [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/chrome/browser/passwords/password_controller_unittest.mm [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/chrome/browser/passwords/resources/password_controller.js [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/chrome/browser/web/resources/chrome_bundle.js [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/web/js_compile.gni [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/web/web_state/js/resources/common.js [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/web/web_state/js/resources/form.js [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/web_view/BUILD.gn [modify] https://crrev.com/fa3c0cd15aff31e47bf79ebbfbdd03c1d7a2b075/ios/web_view/resources/web_view_bundle.js
Comment 1 by eugene...@chromium.org
, Jan 16 2018Labels: -Type-Bug Type-Task