New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802159 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

multiple Windows ToT bots failing HangoutServicesBrowserTest.RunComponentExtensionTest

Project Member Reported by inglorion@chromium.org, Jan 16 2018

Issue description

This has been happening at least since crev.com/529138, clang r322430.

Example logs: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTWin64%2F780%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FHangoutServicesBrowserTest.RunComponentExtensionTest%2F0

Excerpt:
[ RUN      ] HangoutServicesBrowserTest.RunComponentExtensionTest
[3228:5444:0115/212930.163:WARNING:chrome_browser_main_win.cc(616)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=HangoutServicesBrowserTest.RunComponentExtensionTest --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4040_2490\results4040_14723\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ionw8uuc\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4040_2490\d4040_9350" --disable-offline-auto-reload --disable-renderer-backgrounding --autoplay-policy=no-user-gesture-required --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[3228:3444:0115/212931.186:ERROR:audio_manager_base.cc(360)] Invalid audio output parameters received; using fake audio path. Channels: 0, Sample Rate: 0, Bits Per Sample: 0, Frames Per Buffer: 0
[3228:4428:0115/212931.234:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
[3228:5444:0115/212931.309:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212931.514:INFO:CONSOLE(172)] "Starting testCpuGetInfo", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212931.516:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212934.516:INFO:CONSOLE(199)] "Timed out: testCpuGetInfo", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212934.516:INFO:CONSOLE(172)] "Starting testLogging", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212934.517:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212937.518:INFO:CONSOLE(199)] "Timed out: testLogging", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212937.518:INFO:CONSOLE(172)] "Starting testLoggingSetMetaDataAfterStart", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212937.519:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212940.520:INFO:CONSOLE(199)] "Timed out: testLoggingSetMetaDataAfterStart", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212940.520:INFO:CONSOLE(172)] "Starting testDisabledLogging", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212940.522:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212943.522:INFO:CONSOLE(199)] "Timed out: testDisabledLogging", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212943.522:INFO:CONSOLE(172)] "Starting testDisabledLoggingButUpload", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212943.523:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212946.524:INFO:CONSOLE(199)] "Timed out: testDisabledLoggingButUpload", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212946.524:INFO:CONSOLE(172)] "Starting testDisabledLoggingWithStopAndUpload", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212946.525:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212949.527:INFO:CONSOLE(199)] "Timed out: testDisabledLoggingWithStopAndUpload", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212949.527:INFO:CONSOLE(172)] "Starting testEnabledLoggingButDiscard", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212949.529:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212952.529:INFO:CONSOLE(199)] "Timed out: testEnabledLoggingButDiscard", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212952.529:INFO:CONSOLE(172)] "Starting testGetSinks", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212952.530:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212955.530:INFO:CONSOLE(199)] "Timed out: testGetSinks", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212955.530:INFO:CONSOLE(172)] "Starting testGetAssociatedSink", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212955.531:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
[3228:5444:0115/212958.531:INFO:CONSOLE(199)] "Timed out: testGetAssociatedSink", source: http://localhost:52657/extensions/hangout_services_test.js (199)
[3228:5444:0115/212958.531:INFO:CONSOLE(172)] "Starting testIsExtensionEnabled", source: http://localhost:52657/extensions/hangout_services_test.js (172)
[3228:5444:0115/212958.532:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'value' of undefined", source: http://localhost:52657/extensions/hangout_services_test.html (0)
 

Comment 1 by r...@chromium.org, Jan 17 2018

Cc: r...@chromium.org
This is failing on the official continuous builder, so I think this is upstream breakage:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/

This is probably a dupe of https://bugs.chromium.org/p/chromium/issues/detail?id=796601

Comment 2 by r...@chromium.org, Jan 17 2018

By "upstream breakage" I mean Chromium breakage, not clang breakage.
Labels: -clang
Thanks rnk for confirming that this is also broken on the official continuous builder.
Cc: michae...@chromium.org
https://chromium-review.googlesource.com/863103 seems to be the commit at which this started happening, and reverting that locally gets the test to pass without "Cannot read property 'value' of undefined".  Adding @michaelpg to the cc list. I'll see if reverting that commit gets the bots to be green again.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/799f0c03b3e64ae78e662e788ab1eee9e374807f

commit 799f0c03b3e64ae78e662e788ab1eee9e374807f
Author: inglorion <inglorion@chromium.org>
Date: Thu Jan 18 02:33:16 2018

Revert "Move hangout_services extension to //components/extensions"

This reverts commit 010fad40d12a9c85211312d4a9735171787806fe (crrev.com/529086).

Reason for revert:  crbug.com/802159  (official builds failing browser_tests).

TBR=grunell,dgozman,caitkp

Bug:  802159 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idfec077f9d766f512408f20d72c536ff55f36c14
Reviewed-on: https://chromium-review.googlesource.com/872114
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530021}
[modify] https://crrev.com/799f0c03b3e64ae78e662e788ab1eee9e374807f/chrome/browser/browser_resources.grd
[modify] https://crrev.com/799f0c03b3e64ae78e662e788ab1eee9e374807f/chrome/browser/resources/component_extension_resources.grd
[rename] https://crrev.com/799f0c03b3e64ae78e662e788ab1eee9e374807f/chrome/browser/resources/hangout_services/OWNERS
[rename] https://crrev.com/799f0c03b3e64ae78e662e788ab1eee9e374807f/chrome/browser/resources/hangout_services/background.html
[rename] https://crrev.com/799f0c03b3e64ae78e662e788ab1eee9e374807f/chrome/browser/resources/hangout_services/manifest.json
[rename] https://crrev.com/799f0c03b3e64ae78e662e788ab1eee9e374807f/chrome/browser/resources/hangout_services/thunk.js
[delete] https://crrev.com/320e9d6d68b6b347a5bb60ca0eeeab20b9cec9b1/components/extensions/README.md

Labels: -Pri-3 OS-Android OS-Chrome OS-Linux OS-Mac Pri-1
Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)
The revert seems to have fixed the problem according to https://bugs.chromium.org/p/chromium/issues/detail?id=803064#c2. Should wait for confirmation that official build is fine before closing this.
Issue 803064 has been merged into this issue.
Components: Platform>Apps>Hangouts Blink>WebRTC
Cc: grunell@chromium.org
Issue 803223 has been merged into this issue.
Cc: rbasuvula@chromium.org abdulsyed@chromium.org katie@chromium.org gov...@chromium.org nyerramilli@chromium.org
 Issue 802972  has been merged into this issue.
My CL was indeed the culprit, and the revert fixed the given issue.

However, I encounter a different issue when running the test locally -- any idea why it passes on the bots?

I'd like to make sure it passes locally before trying to land a corrected version of my CL. Tried with a variety of different gn args.


[ RUN      ] HangoutServicesBrowserTest.RunComponentExtensionTest
Xlib:  extension "RANDR" missing on display ":99".
Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf
[44698:44698:0118/224243.372812:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[44698:44741:0118/224245.103139:WARNING:simple_synchronous_entry.cc(1173)] Could not open platform files for entry.
[44698:44722:0118/224245.219925:WARNING:simple_synchronous_entry.cc(1173)] Could not open platform files for entry.
[44698:44818:0118/224245.367441:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
[44698:44698:0118/224245.583864:INFO:CONSOLE(172)] "Starting testCpuGetInfo", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44698:0118/224245.604840:INFO:CONSOLE(202)] "Got results for testCpuGetInfo: ", source: http://localhost:44658/extensions/hangout_services_test.js (202)
[44698:44698:0118/224245.605399:INFO:CONSOLE(172)] "Starting testLogging", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44698:0118/224245.647353:INFO:CONSOLE(202)] "Got results for testLogging: ", source: http://localhost:44658/extensions/hangout_services_test.js (202)
[44698:44698:0118/224245.647893:INFO:CONSOLE(172)] "Starting testLoggingSetMetaDataAfterStart", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44698:0118/224245.671880:INFO:CONSOLE(202)] "Got results for testLoggingSetMetaDataAfterStart: ", source: http://localhost:44658/extensions/hangout_services_test.js (202)
[44698:44698:0118/224245.672351:INFO:CONSOLE(172)] "Starting testDisabledLogging", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44698:0118/224245.687915:INFO:CONSOLE(202)] "Got results for testDisabledLogging: ", source: http://localhost:44658/extensions/hangout_services_test.js (202)
[44698:44698:0118/224245.688424:INFO:CONSOLE(172)] "Starting testDisabledLoggingButUpload", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44698:0118/224245.715329:INFO:CONSOLE(202)] "Got results for testDisabledLoggingButUpload: ", source: http://localhost:44658/extensions/hangout_services_test.js (202)
[44698:44698:0118/224245.715869:INFO:CONSOLE(172)] "Starting testDisabledLoggingWithStopAndUpload", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44698:0118/224245.753995:INFO:CONSOLE(202)] "Got results for testDisabledLoggingWithStopAndUpload: ", source: http://localhost:44658/extensions/hangout_services_test.js (202)
[44698:44698:0118/224245.754500:INFO:CONSOLE(172)] "Starting testEnabledLoggingButDiscard", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44698:0118/224245.785633:INFO:CONSOLE(202)] "Got results for testEnabledLoggingButDiscard: ", source: http://localhost:44658/extensions/hangout_services_test.js (202)
[44698:44698:0118/224245.786184:INFO:CONSOLE(172)] "Starting testGetSinks", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44698:0118/224245.794009:INFO:CONSOLE(202)] "Got results for testGetSinks: ", source: http://localhost:44658/extensions/hangout_services_test.js (202)
[44698:44698:0118/224245.794551:INFO:CONSOLE(172)] "Starting testGetAssociatedSink", source: http://localhost:44658/extensions/hangout_services_test.js (172)
[44698:44728:0118/224245.799035:FATAL:webrtc_audio_private_api.cc(285)] Check failed: !raw_sink_id || !raw_sink_id->empty().
#0 0x7fe1721be3ec base::debug::StackTrace::StackTrace()
#1 0x7fe1721e8dbc logging::LogMessage::~LogMessage()
#2 0x0000034c7467 extensions::WebrtcAudioPrivateGetAssociatedSinkFunction::CalculateHMACOnIOThread()
#3 0x0000034c72b2 extensions::WebrtcAudioPrivateGetAssociatedSinkFunction::ReceiveInputDeviceDescriptionsOnIOThread()
#4 0x0000034c8058 _ZN4base8internal13FunctorTraitsIMN10extensions34WebrtcAudioPrivateGetSinksFunctionEFvNSt3__16vectorIN5media22AudioDeviceDescriptionENS4_9allocatorIS7_EEEEEvE6InvokeI13scoped_refptrIS3_EJSA_EEEvSC_OT_DpOT0_
#5 0x7fe16ce4cea8 _ZN4base8internal13FunctorTraitsINS_12OnceCallbackIFvNSt3__16vectorIN5media22AudioDeviceDescriptionENS3_9allocatorIS6_EEEEEEEvE6InvokeISB_JS9_EEEvOT_DpOT0_
#6 0x7fe1721bf34a base::debug::TaskAnnotator::RunTask()
#7 0x7fe1721f2796 base::internal::IncomingTaskQueue::RunTask()
#8 0x7fe1721f6a77 base::MessageLoop::RunTask()
#9 0x7fe1721f6e94 base::MessageLoop::DeferOrRunPendingTask()
#10 0x7fe1721f7158 base::MessageLoop::DoWork()
#11 0x7fe1721f9f69 base::MessagePumpLibevent::Run()
#12 0x7fe1721f62cc base::MessageLoop::Run()
#13 0x7fe17222df36 base::RunLoop::Run()
#14 0x7fe17227207a base::Thread::Run()
#15 0x7fe16e5a9f88 content::BrowserThreadImpl::IOThreadRun()
#16 0x7fe16e5aa1a1 content::BrowserThreadImpl::Run()
#17 0x7fe172272673 base::Thread::ThreadMain()
#18 0x7fe17226882f base::(anonymous namespace)::ThreadFunc()
#19 0x7fe17230c184 start_thread
#20 0x7fe1653ebffd clone

[1/1] HangoutServicesBrowserTest.RunComponentExtensionTest (CRASHED)
1 test crashed:
    HangoutServicesBrowserTest.RunComponentExtensionTest (../../chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:249)



Can you please file a bug for that DCHECK hit?

To proceed, comment out the DCHECK while testing.
Cc: guidou@chromium.org
CC Guido FYI (see comment 12).
Status: Fixed (was: Assigned)
Filed  issue 804836 . Would appreciate if you or Guido could take a look.
Status: Verified (was: Fixed)
Closing this bug as we're not seeing the failure on the bots anymore.

Sign in to add a comment