New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 802144 link

Starred by 2 users
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Jan 2018
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Desktop PWAs: Minimize button overlaps Chrome menu if switching in and out of tablet mode

Project Member Reported by mgiuca@chromium.org, Jan 16 2018 
Chrome Version: 65.0.3299.0
OS: Chrome

What steps will reproduce the problem?
(1) Open an app.
(2) Go into tablet mode (Ctrl+Alt+Shift+T with #ash-debug-shortcuts flag).
(3) Return from tablet mode.

What is the expected result?
Look good.

What happens instead?
Minimize button overlaps Chrome menu. See screenshot.
pwa-tablet-mode.png
1.7 KB View Download

Comment 1 by alancutter@chromium.org, Jan 29 2018

Owner: alancutter@chromium.org
Updated repro instructions:
1. Run ChromeOS with --enable-features=DesktopPWAWindowing --ash-debug-shortcuts
2. Install https://santatracker.google.com/village.html via kebab -> More tools -> Add to shelf...
3. Open Santa Tracker PWApp.
4. Switch in and out of tablet mode with Ctrl-Shift-Alt-T.
5. Observe app kebab menu.

Comment 2 by alancutter@chromium.org, Jan 29 2018 

I suspect the issue comes from adding the kebab menu in
https://cs.chromium.org/?q=function:BrowserNonClientFrameViewAsh::CreateFrameHeader+addChildViewAt
by appending to a FrameCaptionButtonContainerView's child views when the class seems to be fairly hard coded with minimize, resize and close buttons in mind.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/038b610040f4759d2b97cc3713d4771b9dc4eb5c

commit 038b610040f4759d2b97cc3713d4771b9dc4eb5c
Author: Alan Cutter <alancutter@chromium.org>
Date: Wed Jan 31 01:06:17 2018

Fix minimize button sliding into the wrong position when exiting tablet mode

When PWA menu buttons are visible in the title bar we fail to animate the
minimize button to the correct position when exiting tablet mode.

This CL fixes the bug by removing the assumption that the minimize button
is the left-most button and generalises the slide animation to all buttons
left of the size button.

Bug:  802144 
Change-Id: I8ad560c966f9b0fa04beabcf6b96850fe784b5aa
Reviewed-on: https://chromium-review.googlesource.com/892186
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533133}
[modify] https://crrev.com/038b610040f4759d2b97cc3713d4771b9dc4eb5c/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/038b610040f4759d2b97cc3713d4771b9dc4eb5c/ash/frame/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/038b610040f4759d2b97cc3713d4771b9dc4eb5c/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc

Comment 4 by alancutter@chromium.org, Jan 31 2018

Status: Fixed (was: Assigned)

Comment 5 by mgiuca@chromium.org, Jan 31 2018 

Thanks Alan!

Comment 6 by calamity@chromium.org, Feb 26 2018 

Issue 815741 has been merged into this issue.
►

Sign in to add a comment