New issue
Advanced search Search tips

Issue 802143 link

Starred by 1 user
Status: Fixed
Owner:
paulir...@chromium.org
Closed: Jan 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Run audit' and 'Cancel' buttons are not seen properly under 'Audits' section.

Reported by dchau...@etouch.net, Jan 16 2018 
Chrome Version: 65.0.3322.0 (Official Build) 4522efba74e35026b0f62cb1c97d793a92a0d5da-refs/heads/master@{#529187} 32/64-bit.
OS: Win(7,8,8.1,10).

What steps will reproduce the problem?
1. Launch Chrome, open DevTools, doc it to bottom and go to 'Audits' section.
2. Click on 'Perform an audit' button to open 'Audit to perform' overlay and observe.

'Run audit' and 'Cancel' buttons goes out of 'Audit to perform' overlay and looks weird.
'Run audit' and 'Cancel' buttons should not go out of 'Audit to perform' overlay.

This is a regression issue, broken in M-65 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Jan 16 2018

Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: paulir...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

Good build: 65.0.3315.0 (Revision : 527553)
Bad build: 65.0.3316.0 (Revision : 527861)

You are probably looking for a change made after 527816 (known good), but no later than 527817 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/cc2c57abc7f30b02dae2e1436458e78e7aaaa467..8b76a4f045f80c08893009a24e7b677f1bfd3ac4

Suspect: https://chromium.googlesource.com/chromium/src/+/8b76a4f045f80c08893009a24e7b677f1bfd3ac4

@paulirish: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

NOTE: 
1. This issue is also reproducible on Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS) OS.
2. This issue is not reproducible on M-65 Dev build # 65.0.3315.3

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
867 KB View Download
Expected behavior.mp4
1013 KB View Download

Comment 2 by dchau...@etouch.net, Jan 19 2018 

NOTE: To reproduce this issue, freshly launch the Chrome or take a new user and then please perform the steps which is mentioned in the description.

Comment 3 by rbasuvula@chromium.org, Jan 19 2018

Labels: RegressedIn-65 Target-65 FoundIn-65

Comment 4 by paulir...@chromium.org, Jan 19 2018 

Thanks. I have a CL up for review that i'll land/merge for 65: 
https://chromium-review.googlesource.com/c/chromium/src/+/871656

Comment 5 by paulir...@chromium.org, Jan 19 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b5ccf4611baea7e10cdac40715f2c6a7b2951a6

commit 4b5ccf4611baea7e10cdac40715f2c6a7b2951a6
Author: Paul Irish <paulirish@chromium.org>
Date: Sat Jan 20 03:21:09 2018

DevTools: [Audits] Fix overflow for short viewports

Change-Id: I24bda48b2ab0c7c1c3b99a14c88db07e7ba61277
Bug:  802143 
Reviewed-on: https://chromium-review.googlesource.com/871656
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530739}
[modify] https://crrev.com/4b5ccf4611baea7e10cdac40715f2c6a7b2951a6/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/4b5ccf4611baea7e10cdac40715f2c6a7b2951a6/third_party/WebKit/Source/devtools/front_end/audits2/audits2Dialog.css

Comment 7 by paulir...@chromium.org, Jan 20 2018

Status: Fixed (was: Started)

Comment 8 by rbasuvula@chromium.org, Jan 22 2018

Labels: TE-Verified-M66 TE-Verified-66.0.3328.0
Tested the issue on Windows-7, Ubuntu 14.04 and Mac OS 10.13.2 using chrome latest Canary M66-66.0.3328.28 by following steps mentioned in the original comment. Observed that 'Run audit' and 'Cancel' buttons are displaying as expected. Hence adding TE-Verified label.

Please find the screen shot for reference.

Thank you!
802143.PNG
180 KB View Download

Comment 9 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported
►

Sign in to add a comment