New issue
Advanced search Search tips

Issue 802107 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

macOS 10.9: Check failed: [view isDescendantOf:frameView] when displaying a permission bubble in tab fullscreen.

Project Member Reported by tapted@chromium.org, Jan 16 2018 
Chrome Version       : 65.0.3294.5
OS Version: OS X 10.9

Trying to refactor permissions bubbles tests on Mac for more authentic code coverage, I managed to tickle this DCHECK.

I'm going to try bringing up the test with the old, lesser code coverage instead.

CL: https://chromium-review.googlesource.com/c/chromium/src/+/866523
try-run: https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/628220
failure: https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F628220%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests__with_patch_%2F0%2Flogs%2FPermissionBubbleBrowserTest.TabFullscreenHasLocationBar%2F0

Error like

[ RUN      ] PermissionBubbleBrowserTest.TabFullscreenHasLocationBar
[6142:55299:0115/182050.943550:WARNING:mac_util.mm(226)] Failed to set backup exclusion for file '/private/var/folders/p4/py6nlvcx4fs5s3fg51_pzqmc0000gm/T/.org.chromium.Chromium.Rk1PsU/dmELRCw/Default/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[6142:5123:0115/182050.950640:WARNING:notification_platform_bridge_mac.mm(533)] AlertNotificationService: XPC connection invalidated.
[6148:771:0115/182051.019602:WARNING:vt_video_decode_accelerator_mac.cc(177)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973)
[6148:771:0115/182051.020553:WARNING:vt_video_decode_accelerator_mac.cc(199)] Failed to create hardware VideoToolbox session
[6148:771:0115/182051.077129:ERROR:vt_video_encode_accelerator_mac.cc(517)]  VTCompressionSessionCreate failed: -12908
[6142:55299:0115/182051.158461:WARNING:mac_util.mm(226)] Failed to set backup exclusion for file '/private/var/folders/p4/py6nlvcx4fs5s3fg51_pzqmc0000gm/T/.org.chromium.Chromium.Rk1PsU/dmELRCw/Default/Favicons': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[6148:771:0115/182051.830314:WARNING:ca_layer_tree_coordinator.mm(55)] Blank frame: No overlays or CALayers
[6148:771:0115/182052.085212:WARNING:ca_layer_tree_coordinator.mm(55)] Blank frame: No overlays or CALayers
[6148:771:0115/182052.085388:WARNING:ca_layer_tree_coordinator.mm(55)] Blank frame: No overlays or CALayers
[6148:771:0115/182052.085531:WARNING:ca_layer_tree_coordinator.mm(55)] Blank frame: No overlays or CALayers
2018-01-15 18:20:52.113 browser_tests[6142:303] Invalid color System, labelColor (warning given only once)
[6142:771:0115/182052.143873:FATAL:nsgraphics_context_additions.mm(21)] Check failed: [view isDescendantOf:frameView].
0   browser_tests                       0x0000000105a978ac base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x0000000105abc000 logging::LogMessage::~LogMessage() + 224
2   browser_tests                       0x00000001072aa83c -[NSGraphicsContext(CrAdditions) cr_setPatternPhase:forView:] + 220
3   browser_tests                       0x000000010996e054 -[BackgroundGradientView drawBackground:] + 116
4   browser_tests                       0x0000000109a7a5b6 -[ToolbarView drawRect:] + 38
5   AppKit                              0x00007fff86fa9557 -[NSView(NSInternal) _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:] + 1082
6   AppKit                              0x00007fff86fa900d __46-[NSView(NSLayerKitGlue) drawLayer:inContext:]_block_invoke + 186
7   AppKit                              0x00007fff86fa8e03 -[NSView(NSLayerKitGlue) _drawViewBackingLayer:inContext:drawingHandler:] + 2297
8   AppKit                              0x00007fff86fa84f8 -[NSView(NSLayerKitGlue) drawLayer:inContext:] + 108
9   QuartzCore                          0x00007fff91cde812 CABackingStoreUpdate_ + 2220
10  QuartzCore                          0x00007fff91cddf60 ___ZN2CA5Layer8display_Ev_block_invoke + 59
11  QuartzCore                          0x00007fff91cddf1c x_blame_allocations + 84
12  QuartzCore                          0x00007fff91cdda2b CA::Layer::display_() + 1539
13  AppKit                              0x00007fff86fa83c3 _NSBackingLayerDisplay + 235
14  AppKit                              0x00007fff86f7f74b -[_NSViewBackingLayer display] + 811
15  QuartzCore                          0x00007fff91cdd162 CA::Layer::display_if_needed(CA::Transaction*) + 590
16  QuartzCore                          0x00007fff91cdc8b1 CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 35
17  QuartzCore                          0x00007fff91cdc33c CA::Context::commit_transaction(CA::Transaction*) + 236
18  QuartzCore                          0x00007fff91cdbfd6 CA::Transaction::commit() + 388
19  AppKit                              0x00007fff86fa7652 -[NSView(NSLayerKitGlue) _drawRectAsLayerTree:] + 591
20  AppKit                              0x00007fff86fa6351 -[NSView _drawRect:clip:] + 422
21  AppKit                              0x00007fff86fa58c4 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 1799
22  AppKit                              0x00007fff86fa5ca0 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2787
23  AppKit                              0x00007fff86fa5ca0 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2787
24  AppKit                              0x00007fff86fa3706 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 841
25  AppKit                              0x00007fff870d2c13 -[NSNextStepFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 303
26  AppKit                              0x00007fff86f9fe9f -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 2828
27  AppKit                              0x00007fff86f7f2da -[NSView displayIfNeeded] + 1680
28  AppKit                              0x00007fff870c93eb -[NSNextStepFrame displayIfNeeded] + 156
29  AppKit                              0x00007fff86f69499 -[NSWindow _setFrameCommon:display:stashSize:] + 3262
30  AppKit                              0x00007fff86f68164 -[NSWindow setFrame:display:animate:] + 145
31  browser_tests                       0x0000000106ee7cef views::BridgedNativeWidget::SetBounds(gfx::Rect const&) + 991
32  browser_tests                       0x0000000106f6a315 views::NativeWidgetMac::SetSize(gfx::Size const&) + 133
33  browser_tests                       0x0000000106f69f66 views::NativeWidgetMac::CenterWindow(gfx::Size const&) + 54
34  browser_tests                       0x0000000106f7202d views::Widget::SetInitialBounds(gfx::Rect const&) + 333
35  browser_tests                       0x0000000106f716b3 views::Widget::Init(views::Widget::InitParams const&) + 1075
36  browser_tests                       0x0000000106edca92 views::BubbleDialogDelegateView::CreateBubble(views::BubbleDialogDelegateView*) + 226
37  browser_tests                       0x0000000109afe725 PermissionPromptImpl::Show() + 229
38  browser_tests                       0x0000000109a3cf1e PermissionPrompt::Create(content::WebContents*, PermissionPrompt::Delegate*) + 62
39  browser_tests                       0x0000000105dd3765 base::internal::Invoker<base::internal::BindState<std::__1::unique_ptr<PermissionPrompt, std::__1::default_delete<PermissionPrompt> > (*)(content::WebContents*, PermissionPrompt::Delegate*)>, std::__1::unique_ptr<PermissionPrompt, std::__1::default_delete<PermissionPrompt> > (content::WebContents*, PermissionPrompt::Delegate*)>::Run(base::internal::BindStateBase*, content::WebContents*, PermissionPrompt::Delegate*) + 21
40  browser_tests                       0x0000000105dd270b PermissionRequestManager::ShowBubble(bool) + 299
41  browser_tests                       0x000000010419cc05 content::WebContentsImpl::WasShown() + 405
42  AppKit                              0x00007fff86e5f190 -[NSView _setWindow:] + 2899
43  CoreFoundation                      0x00007fff8ea502f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
44  CoreFoundation                      0x00007fff8ea4fa9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
45  AppKit                              0x00007fff875a2c72 __21-[NSView _setWindow:]_block_invoke712 + 231
46  AppKit                              0x00007fff86e5f15f -[NSView _setWindow:] + 2850
47  CoreFoundation                      0x00007fff8ea502f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
48  CoreFoundation                      0x00007fff8ea4fa9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
49  AppKit                              0x00007fff875a2c72 __21-[NSView _setWindow:]_block_invoke712 + 231
50  AppKit                              0x00007fff86e5f15f -[NSView _setWindow:] + 2850
51  CoreFoundation                      0x00007fff8ea502f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
52  CoreFoundation                      0x00007fff8ea4fa9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
53  AppKit                              0x00007fff875a2c72 __21-[NSView _setWindow:]_block_invoke712 + 231
54  AppKit                              0x00007fff86e5f15f -[NSView _setWindow:] + 2850
55  CoreFoundation                      0x00007fff8ea502f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
56  CoreFoundation                      0x00007fff8ea4fa9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
57  AppKit                              0x00007fff875a2c72 __21-[NSView _setWindow:]_block_invoke712 + 231
58  AppKit                              0x00007fff86e5f15f -[NSView _setWindow:] + 2850
59  CoreFoundation                      0x00007fff8ea502f9 __53-[__NSArrayM enumerateObjectsWithOptions:usingBlock:]_block_invoke + 137
60  CoreFoundation                      0x00007fff8ea4fa9f -[__NSArrayM enumerateObjectsWithOptions:usingBlock:] + 319
61  AppKit                              0x00007fff875a2c72 __21-[NSView _setWindow:]_block_invoke712 + 231
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8586c2395c158e2330c7161195125fcae97d0333

commit 8586c2395c158e2330c7161195125fcae97d0333
Author: Trent Apted <tapted@chromium.org>
Date: Wed Jan 17 05:31:49 2018

Remove Cocoa permissions bubble code.

They were crashy. MacViews bubbles have been used 100% since m63. So
these are now just dead code.

Note permission_bubble_cocoa_interactive_uitest.mm stays. It still tests
with and without --secondary-ui-md, but now both will use toolkit-views
for the UI. It will be slightly different. E.g. --secondary-ui-md will
anchor differently, and without an arrow.

Port the tests in permission_bubble_cocoa_browser_test.mm to use views
bubbles instead.

BUG=692007,  802107 

Change-Id: I045d840cb0e5c5d2f1c80a7e4f54f11ae479640f
Reviewed-on: https://chromium-review.googlesource.com/866523
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529627}
[modify] https://crrev.com/8586c2395c158e2330c7161195125fcae97d0333/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8586c2395c158e2330c7161195125fcae97d0333/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/8586c2395c158e2330c7161195125fcae97d0333/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[delete] https://crrev.com/a759ecf4c9f65609066602fd8c5b8cd51cdadd22/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h
[delete] https://crrev.com/a759ecf4c9f65609066602fd8c5b8cd51cdadd22/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm
[delete] https://crrev.com/a759ecf4c9f65609066602fd8c5b8cd51cdadd22/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h
[delete] https://crrev.com/a759ecf4c9f65609066602fd8c5b8cd51cdadd22/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm
[delete] https://crrev.com/a759ecf4c9f65609066602fd8c5b8cd51cdadd22/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm
[rename] https://crrev.com/8586c2395c158e2330c7161195125fcae97d0333/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
[modify] https://crrev.com/8586c2395c158e2330c7161195125fcae97d0333/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm
[modify] https://crrev.com/8586c2395c158e2330c7161195125fcae97d0333/chrome/test/BUILD.gn

Comment 2 by tapted@chromium.org, Feb 13 2018

Status: Fixed (was: Available)
►

Sign in to add a comment