New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802104 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Use TBM framework for tab_switching benchmark

Project Member Reported by sadrul@chromium.org, Jan 16 2018

Issue description

Use the new TBM framework for tab_switching benchmark. Once the TBM-based benchmark is available, we can remove the legacy code for this [1, 2].

[1] https://cs.chromium.org/chromium/src/tools/perf/benchmarks/tab_switching.py
[2] https://cs.chromium.org/chromium/src/tools/perf/measurements/tab_switching.py
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8100dc0019e9e0856da0b5711e76135b0f022cc

commit d8100dc0019e9e0856da0b5711e76135b0f022cc
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Jan 25 08:54:25 2018

Roll src/third_party/catapult/ e99797e78..62619cb4a (1 commit)

https://chromium.googlesource.com/catapult.git/+log/e99797e78121..62619cb4a9ae

$ git log e99797e78..62619cb4a --date=short --no-merges --format='%ad %ae %s'
2018-01-23 sadrul tabs: Add a TBM metric for tab_switching.

Created with:
  roll-dep src/third_party/catapult
BUG= 802104 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I0fc3060a5238dcb88de1069b738a0b58a70ceb5c
Reviewed-on: https://chromium-review.googlesource.com/886181
Commit-Queue: <catapult-deps-roller@chromium.org>
Reviewed-by: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531852}
[modify] https://crrev.com/d8100dc0019e9e0856da0b5711e76135b0f022cc/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43487fc89193d2cd284c17d355787727482763bd

commit 43487fc89193d2cd284c17d355787727482763bd
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Thu Jan 25 16:21:42 2018

tab_switching: Switch over to the new tbm metric.

Switch the tab_switching benchmark to use the new TBMv2 metric for
measuring tab-switching latency.

BUG= 802104 

Change-Id: I7ab9610811b842feacf3a28845a2b267de4bfd20
Reviewed-on: https://chromium-review.googlesource.com/886003
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531912}
[modify] https://crrev.com/43487fc89193d2cd284c17d355787727482763bd/tools/perf/benchmarks/tab_switching.py
[delete] https://crrev.com/cdb51726002968dfa4f0e88e44b6b69488275f25/tools/perf/measurements/tab_switching.py
[delete] https://crrev.com/cdb51726002968dfa4f0e88e44b6b69488275f25/tools/perf/measurements/tab_switching_unittest.py

There is a version of tab_switching for Chrome OS in contrib/cros_benchmarks/tab_switching_bench.py. Will this change affect it as well?

Comment 5 by maxlg@chromium.org, Jun 13 2018

ping.

Comment 6 by sadrul@chromium.org, Jun 13 2018

Status: Fixed (was: Started)

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment