New issue
Advanced search Search tips

Issue 802095 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-align] 'left' and 'right' should parse as invalid in block/cross-axis alignment

Project Member Reported by jfernan...@igalia.com, Jan 16 2018

Issue description

'The CSS WG has resolved that the 'left' and 'right' values should be removed from the block/cross-axis alignment properties (align-self and align-items). 

https://github.com/w3c/csswg-drafts/issues/1403#issuecomment-311722607



 
The same applies to the align-content and justify-content properties.
Components: Blink>CSS
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/841ce846af10f5855f09fa7db77dd53e680080bf

commit 841ce846af10f5855f09fa7db77dd53e680080bf
Author: Javier Fernandez <jfernandez@igalia.com>
Date: Tue Jan 23 00:17:35 2018

[css-align] The 'left' and 'right' values must be invalid in block axis

The CSS WG resolved to remove the 'left' and 'right' values from the
block/cross axis alignment properties.

https://github.com/w3c/csswg-drafts/issues/1403

This CL changes the CSS parsing logic of all the CSS Box Alignment
properties, both block-axis (align-{self, items, content} and
inline-axis (justify-{self, items, content}).

Additionally, the alignment shorthands (place-{self, items, content})
have been also changed to respect the new syntax.

This change also affects the Grid Layout alignment logic.

Bug:  802095 
Change-Id: Id848ce22a9b2d69ecf2bfd58503f590e4b2fe4db
Reviewed-on: https://chromium-review.googlesource.com/877519
Reviewed-by: meade_(do not use) <meade@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#531074}
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-align-content-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-align-content-004.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-align-content-005.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-justify-content-001.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-justify-content-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-justify-content-003.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-001.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-004.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-006.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-align-items-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-align-items-004.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-align-items-005.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-001.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-003.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-004.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-001.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-004.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-006.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/resources/alignment-parsing-utils.js
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-align-self-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-align-self-004.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-align-self-005.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-justify-self-001.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-justify-self-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-justify-self-003.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-001.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-002.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-004.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-006.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/alignment/parse-align-content.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html
[delete] https://crrev.com/4de9656f3804756923df93751e8991a0167cd3ad/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self-expected.txt
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements.html
[delete] https://crrev.com/4de9656f3804756923df93751e8991a0167cd3ad/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding-expected.txt
[delete] https://crrev.com/4de9656f3804756923df93751e8991a0167cd3ad/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr-expected.txt
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html
[delete] https://crrev.com/4de9656f3804756923df93751e8991a0167cd3ad/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl-expected.txt
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding.html
[delete] https://crrev.com/4de9656f3804756923df93751e8991a0167cd3ad/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding-expected.txt
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-change-alignment-from-stretch.html
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-alignment.css
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.cpp
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.h
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/css/properties/longhands/AlignContentCustom.cpp
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/css/properties/longhands/AlignItemsCustom.cpp
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/css/properties/longhands/AlignSelfCustom.cpp
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/css/properties/longhands/JustifyContentCustom.cpp
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/css/properties/longhands/JustifyItemsCustom.cpp
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/css/properties/longhands/JustifySelfCustom.cpp
[modify] https://crrev.com/841ce846af10f5855f09fa7db77dd53e680080bf/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Labels: Hotlist-Interop
Have we shipped support? If so, should we have a Deprecate and Remove?
Umm, I might have asked for Deprecate and Remove, indeed. However, these two values were removed from the spec back in june already and were doing nothing for the CSS properties affected by this change. I thought it was clearly zero interop risk, but I agree that I should have send the forma request to the mailing list.

I don't mind to roll it out and send the formal request if anybody considers it more convenient. 
Status: Fixed (was: Started)
This issue should be FIXED now.

Sign in to add a comment