VR: Omnibox hidden after returning to Chrome when exiting VR by leaving Chrome |
|||
Issue descriptionApparently when we tell Chrome to show the omnibox, if Chrome isn't currently visible(?) that's just ignored and the omnibox is hidden when we return to Chrome. Repro: 1. Enter WebVR. 2. Press system UI home button. 3. Return to Chrome. Notice missing omnibox.
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58c7f9d66e579c353b59e1154912b53be2061523 commit 58c7f9d66e579c353b59e1154912b53be2061523 Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Jan 17 15:26:48 2018 VR: Wait until Compositor frame is produced before pausing VSync We need to wait until the compositor has produced a frame before pausing VSync so that the omnibox code gets into the correct state where it thinks the omnibox is hidden (though it may still be animating out). This fixes the issue where the omnibox thinks it's still visible when exiting WebVR, and fails to re-show the omnibox. Bug: 802090 Change-Id: Iab9807e5ef58b98421726e8917cf69dc6251be74 Reviewed-on: https://chromium-review.googlesource.com/867948 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#529749} [modify] https://crrev.com/58c7f9d66e579c353b59e1154912b53be2061523/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/58c7f9d66e579c353b59e1154912b53be2061523/chrome/browser/android/vr_shell/vr_compositor.cc [modify] https://crrev.com/58c7f9d66e579c353b59e1154912b53be2061523/chrome/browser/android/vr_shell/vr_compositor.h [modify] https://crrev.com/58c7f9d66e579c353b59e1154912b53be2061523/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/58c7f9d66e579c353b59e1154912b53be2061523/chrome/browser/android/vr_shell/vr_shell.h
,
Jan 17 2018
,
Feb 7 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mthiesse@chromium.org
, Jan 16 2018