Race in SitePerProcessBrowserTest.InputEventRouterTouchpadGestureTargetTest |
||
Issue descriptionA small modification to asynchronous hit testing in https://chromium-review.googlesource.com/c/chromium/src/+/865815 causes flakiness on InputEventRouterTouchPadGestureTargetTest, even though events are being routed correctly. Locally, the test fails 80-90% of the time with my patch applied, and I believe this is just from my change causing asynchronous hit testing to take a bit longer in some cases. It appears that this relates to scroll bubbling. On most runs, when the test sends a GestureFlingStart event to the child frame, RenderWidgetHostViewChildFrame::ProcessGestureEvent discards the event because is_scroll_sequence_bubbling_ is set. I haven't gone further in investigating what is causing that to be set prematurely, but I am planning to disable the test so that I can land the change.
,
Jan 17 2018
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbb1c646b962308f397996719ec263b81a1390c7 commit cbb1c646b962308f397996719ec263b81a1390c7 Author: Kevin McNee <mcnee@chromium.org> Date: Fri Feb 02 21:35:20 2018 Don't substitute GestureFlingStarts with GestureScrollEnds when bubbling We were substituting GFS events with GSE events when bubbling scroll from an OOPIF. This was done to prevent an OOPIF based guest from consuming a fling that is intended for bubbling (see crbug.com/770852 ). It seems that this can lead to an invalid input event stream. Fortunately, the main concern in that bug was with GestureScrollUpdates. The fling was a minor issue. The filtering of GSU events is still valid, so we only remove the GFS substitution. Bug: 770852 , 806940, 802085 Change-Id: I647471ea4ff94396ef6e6af21fb89e1841a0eaf7 Reviewed-on: https://chromium-review.googlesource.com/899878 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#534160} [modify] https://crrev.com/cbb1c646b962308f397996719ec263b81a1390c7/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/cbb1c646b962308f397996719ec263b81a1390c7/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/cbb1c646b962308f397996719ec263b81a1390c7/content/browser/site_per_process_hit_test_browsertest.cc
,
Feb 2 2018
The test is reenabled. |
||
►
Sign in to add a comment |
||
Comment 1 by mcnee@chromium.org
, Jan 16 2018