VR: Add support for Chrome icon in Daydream Home. |
|||||
Issue descriptionUsers should be able to launch Chrome in VR from Daydream Home. This tracks adding this capability behind a flag.
,
Jan 17 2018
Note that we can't enable this by default until the fixes for b/71870573 and b/71994343 roll out to 100% of users, even if we get daydream/play sign-off.
,
Jan 17 2018
leilei/david we may want to add a manual test for this to make sure it doesn't break. You can message me for the details on how to get this working.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c357720eef65cf038f52093a5a20e25b448c8cd commit 0c357720eef65cf038f52093a5a20e25b448c8cd Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Jan 18 20:27:52 2018 Revert "VR: Add dynamically-toggled icon in Daydream Home" This reverts commit 559f95d6420338760f285a1b726abffd8a8bcd1c. Reason for revert: Fails APK validation because of 'missing Daydream icons'. Original change's description: > VR: Add dynamically-toggled icon in Daydream Home > > This CL adds the ability to show the Chrome icon in Daydream Home, which > launches Chrome in VR mode, behind a feature flag. > > We're able to do this by enabling/disabling the component that adds the > icon at runtime. > > Bug: 802080 > Change-Id: I878202c110d2a7bd092173457de73ce1578d2ff6 > Reviewed-on: https://chromium-review.googlesource.com/867512 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Yash Malik <ymalik@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529842} TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 802080 Change-Id: I9a01dc2dcfaa0e5de07ccc16671721d61beb6feb Reviewed-on: https://chromium-review.googlesource.com/874781 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#530252} [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/chrome/browser/about_flags.cc [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/chrome/browser/flag_descriptions.h [modify] https://crrev.com/0c357720eef65cf038f52093a5a20e25b448c8cd/tools/metrics/histograms/enums.xml
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c1967840d59d494ab8d55a24e37da79b0a92c52 commit 4c1967840d59d494ab8d55a24e37da79b0a92c52 Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Jan 19 16:24:09 2018 Reland "VR: Add dynamically-toggled icon in Daydream Home" This reverts commit 0c357720eef65cf038f52093a5a20e25b448c8cd. Original change's description: > Revert "VR: Add dynamically-toggled icon in Daydream Home" > > This reverts commit 559f95d6420338760f285a1b726abffd8a8bcd1c. > > Reason for revert: Fails APK validation because of 'missing Daydream icons'. > > Original change's description: > > VR: Add dynamically-toggled icon in Daydream Home > > > > This CL adds the ability to show the Chrome icon in Daydream Home, which > > launches Chrome in VR mode, behind a feature flag. > > > > We're able to do this by enabling/disabling the component that adds the > > icon at runtime. > > > > Bug: 802080 > > Change-Id: I878202c110d2a7bd092173457de73ce1578d2ff6 > > Reviewed-on: https://chromium-review.googlesource.com/867512 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Yash Malik <ymalik@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#529842} > > TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 802080 > Change-Id: I9a01dc2dcfaa0e5de07ccc16671721d61beb6feb > Reviewed-on: https://chromium-review.googlesource.com/874781 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530252} TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org Change-Id: Id5738ec9f9e67ef52d57d99af33e450b0af6e0ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 802080 Reviewed-on: https://chromium-review.googlesource.com/875070 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#530531} [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/android/java/AndroidManifest.xml [add] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/android/java/res/drawable-nodpi/daydream_icon_background.png [add] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/android/java/res/drawable-nodpi/daydream_icon_foreground.png [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/browser/about_flags.cc [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/chrome/browser/flag_descriptions.h [modify] https://crrev.com/4c1967840d59d494ab8d55a24e37da79b0a92c52/tools/metrics/histograms/enums.xml
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d7412729393ca147dbfa66ee6598e652476364e commit 1d7412729393ca147dbfa66ee6598e652476364e Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Jan 19 18:02:54 2018 Revert "Reland "VR: Add dynamically-toggled icon in Daydream Home"" This reverts commit 4c1967840d59d494ab8d55a24e37da79b0a92c52. Reason for revert: Failed downstream on the x64 Android bots. 'Unused resources'. Original change's description: > Reland "VR: Add dynamically-toggled icon in Daydream Home" > > This reverts commit 0c357720eef65cf038f52093a5a20e25b448c8cd. > > Original change's description: > > Revert "VR: Add dynamically-toggled icon in Daydream Home" > > > > This reverts commit 559f95d6420338760f285a1b726abffd8a8bcd1c. > > > > Reason for revert: Fails APK validation because of 'missing Daydream icons'. > > > > Original change's description: > > > VR: Add dynamically-toggled icon in Daydream Home > > > > > > This CL adds the ability to show the Chrome icon in Daydream Home, which > > > launches Chrome in VR mode, behind a feature flag. > > > > > > We're able to do this by enabling/disabling the component that adds the > > > icon at runtime. > > > > > > Bug: 802080 > > > Change-Id: I878202c110d2a7bd092173457de73ce1578d2ff6 > > > Reviewed-on: https://chromium-review.googlesource.com/867512 > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > > Reviewed-by: Yash Malik <ymalik@chromium.org> > > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#529842} > > > > TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 802080 > > Change-Id: I9a01dc2dcfaa0e5de07ccc16671721d61beb6feb > > Reviewed-on: https://chromium-review.googlesource.com/874781 > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#530252} > > TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org > > Change-Id: Id5738ec9f9e67ef52d57d99af33e450b0af6e0ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 802080 > Reviewed-on: https://chromium-review.googlesource.com/875070 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530531} TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org Change-Id: Idcd8f40b0f49c9959619e5cbf6ed0dcee6b615d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 802080 Reviewed-on: https://chromium-review.googlesource.com/876263 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#530558} [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/chrome/android/java/AndroidManifest.xml [delete] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/android/java/res/drawable-nodpi/daydream_icon_background.png [delete] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/android/java/res/drawable-nodpi/daydream_icon_foreground.png [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/chrome/browser/about_flags.cc [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/chrome/browser/flag_descriptions.h [modify] https://crrev.com/1d7412729393ca147dbfa66ee6598e652476364e/tools/metrics/histograms/enums.xml
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/378959124b9103b0bd426c855ef5a2a74ed0c19b commit 378959124b9103b0bd426c855ef5a2a74ed0c19b Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Jan 19 20:15:54 2018 Reland "Reland "VR: Add dynamically-toggled icon in Daydream Home"" Original change's description: > Revert "Reland "VR: Add dynamically-toggled icon in Daydream Home"" > > This reverts commit 4c1967840d59d494ab8d55a24e37da79b0a92c52. > > Reason for revert: Failed downstream on the x64 Android bots. 'Unused resources'. > > Original change's description: > > Reland "VR: Add dynamically-toggled icon in Daydream Home" > > > > This reverts commit 0c357720eef65cf038f52093a5a20e25b448c8cd. > > > > Original change's description: > > > Revert "VR: Add dynamically-toggled icon in Daydream Home" > > > > > > This reverts commit 559f95d6420338760f285a1b726abffd8a8bcd1c. > > > > > > Reason for revert: Fails APK validation because of 'missing Daydream icons'. > > > > > > Original change's description: > > > > VR: Add dynamically-toggled icon in Daydream Home > > > > > > > > This CL adds the ability to show the Chrome icon in Daydream Home, which > > > > launches Chrome in VR mode, behind a feature flag. > > > > > > > > We're able to do this by enabling/disabling the component that adds the > > > > icon at runtime. > > > > > > > > Bug: 802080 > > > > Change-Id: I878202c110d2a7bd092173457de73ce1578d2ff6 > > > > Reviewed-on: https://chromium-review.googlesource.com/867512 > > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > > > Reviewed-by: Yash Malik <ymalik@chromium.org> > > > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#529842} > > > > > > TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 802080 > > > Change-Id: I9a01dc2dcfaa0e5de07ccc16671721d61beb6feb > > > Reviewed-on: https://chromium-review.googlesource.com/874781 > > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#530252} > > > > TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org > > > > Change-Id: Id5738ec9f9e67ef52d57d99af33e450b0af6e0ad > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 802080 > > Reviewed-on: https://chromium-review.googlesource.com/875070 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#530531} > > TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org > > Change-Id: Idcd8f40b0f49c9959619e5cbf6ed0dcee6b615d2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 802080 > Reviewed-on: https://chromium-review.googlesource.com/876263 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530558} TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org Bug: 802080 Change-Id: Ie51c6022bce6adbf0c7f2d39f4755829d88b84b8 Reviewed-on: https://chromium-review.googlesource.com/876622 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#530598} [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/android/BUILD.gn [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/android/java/AndroidManifest.xml [add] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/android/java/res_vr/drawable-nodpi/daydream_icon_background.png [add] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/android/java/res_vr/drawable-nodpi/daydream_icon_foreground.png [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/browser/about_flags.cc [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/chrome/browser/flag_descriptions.h [modify] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/tools/metrics/histograms/enums.xml
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/538399f90b82352e47d8783e58671be6efb2958f commit 538399f90b82352e47d8783e58671be6efb2958f Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Jan 23 20:31:26 2018 Fix Canary push due to invalid Daydream icons Daydream expects its icons to be in png format, and play store validation will fail if it doesn't find correctly formatted icons. This excludes '.dd.png' files from the automatic conversion to webp when building ChromeModern See b/72294258. TBR=dtrainor@chromium.org Bug: 802080 Change-Id: Icd55d5a08536697ec97c08701782c925165631c0 Reviewed-on: https://chromium-review.googlesource.com/881461 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#531335} [modify] https://crrev.com/538399f90b82352e47d8783e58671be6efb2958f/build/android/gyp/process_resources.py [rename] https://crrev.com/538399f90b82352e47d8783e58671be6efb2958f/chrome/android/java/res_vr/drawable-nodpi/daydream_icon_background.dd.png [rename] https://crrev.com/538399f90b82352e47d8783e58671be6efb2958f/chrome/android/java/res_vr/drawable-nodpi/daydream_icon_foreground.dd.png
,
Feb 7 2018
,
Mar 7 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 17 2018