1. Read http://errorprone.info/bugpattern/ReferenceEquality 2. Remove 'ReferenceEquality' suppression for errorprone. 3. Fix or suppress each instance in code. 4. Upgrade 'ReferenceEquality' to errorprone error to prevent future regressions.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00f0b3424bab8fb3c029729b2b91c1fa73ee596b commit 00f0b3424bab8fb3c029729b2b91c1fa73ee596b Author: Rob Buis <rob.buis@samsung.com> Date: Wed Mar 14 22:41:43 2018 Fix errorprone ReferenceEquality warnings Fix errorprone ReferenceEquality warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/ReferenceEquality Bug: 802075 Change-Id: Icd9d0ccd0f625b1eef1d92d88600641b67a8587a Reviewed-on: https://chromium-review.googlesource.com/911609 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#543225} [modify] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/build/android/gyp/javac.py [modify] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java [modify] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java [modify] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java [modify] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java [modify] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java [modify] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java
Comment 1 by rob.b...@samsung.com
, Mar 14 2018Status: Started (was: Available)