New issue
Advanced search Search tips

Issue 802058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 714618



Sign in to add a comment

Password manager masks unmasked passwords after one is deleted

Reported by reeves.j...@gmail.com, Jan 15 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.85 Safari/537.36

Steps to reproduce the problem:
1.  Visit password manager.
2.  Unmask multiple passwords.
3.  Delete one password row.

What is the expected behavior?
All other unmasked passwords remain unmasked.

What went wrong?
All unmasked passwords are re-masked.

Did this work before? Yes I just jumped up to beta to check to see if a bug was fixed, but last Current Release 63.0.3239.132 it was working as expected.

Chrome version: 64.0.3282.85  Channel: beta
OS Version: OS X 10.13.2
Flash Version: 

Bug was fixed (https://crrev.com/c/779179) resulting in this issue of the passwords becoming re-masked after single deletion.
 

Comment 1 by meh...@chromium.org, Jan 15 2018

Components: UI>Browser>Passwords

Comment 2 by battre@chromium.org, Jan 15 2018

Owner: jdoerrie@chromium.org
Status: Assigned (was: Unconfirmed)
should this be fixed on m64 beta already?
Cc: vabr@chromium.org kolos@chromium.org
No, this is an actual "bug", resulting from the fix in https://crrev.com/c/779179. Due to legacy reasons we refresh the settings page after changes to the password store, resulting in the described masking of passwords after deletion. Ideally we would fix this and handle deletion events similarly to how MD Bookmarks does it, but that requires a quite large refactoring.

Adding relevant folks so that they are also aware of this issue.

Comment 4 by kolos@chromium.org, Jan 26 2018

Blocking: 714618
Cc: -vabr@chromium.org
vabr going hobby only -> reducing involvement.
Please contact me directly in urgent matters.
Status: Fixed (was: Assigned)

Sign in to add a comment