New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802056 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: 2018-03-07
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 810854



Sign in to add a comment

Add secondary action button to toolbar

Project Member Reported by bauerb@chromium.org, Jan 15 2018

Issue description

Add the ability to show a secondary action button in the toolbar for Custom Tabs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb22e7949877705f141b70a8734c23de0c46cdc6

commit cb22e7949877705f141b70a8734c23de0c46cdc6
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Wed Feb 07 16:38:37 2018

🛃 Allow multiple action buttons in custom tab toolbar

Add a non-public flag to the TOOLBAR_ITEMS bundle extra, indicating that
the item should be shown on the top toolbar even if it doesn't have the
TOOLBAR_ACTION_BUTTON_ID. For now this allows showing a maximum number
of 2 buttons in the toolbar; any additional items will go into the
bottom bar.

Screenshot: https://photos.app.goo.gl/UkFRghtJ4cSIT6q53

Also, clean up CustomTabActivityTest (replace anonymous classes with
lamdas, simplify exceptions, etc.).

Bug:  802056 
Change-Id: I0f407356ec62e104781d683db3d2f32ebff4ce7e
Reviewed-on: https://chromium-review.googlesource.com/888921
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535026}
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/res/layout/custom_tabs_toolbar.xml
[add] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/res/layout/custom_tabs_toolbar_button.xml
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomButtonParams.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/cb22e7949877705f141b70a8734c23de0c46cdc6/chrome/android/javatests/src/org/chromium/chrome/browser/test/ScreenShooter.java

Comment 2 by bauerb@chromium.org, Feb 26 2018

Blocking: 810854

Comment 3 by bauerb@chromium.org, Feb 26 2018

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/9ec067102cde99a499dd7588ddf6547d7780d827

commit 9ec067102cde99a499dd7588ddf6547d7780d827
Author: Bernhard Bauer <bauerb@google.com>
Date: Mon Mar 05 11:29:29 2018

NextAction: 2018-03-07
Labels: Merge-Request-66
I'd like to merge https://chrome-internal.googlesource.com/clank/internal/apps/+/9ec067102cde99a499dd7588ddf6547d7780d827 to the 66 branch. It's a very small change that only bumps a version number that is only sent to first-party clients of Custom Tabs, it has tests and has gone through a Canary release.
The NextAction date has arrived: 2018-03-07
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 8 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 8 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/b29d7eda5e4e996c1a33d2ccb870416b76d354ac

commit b29d7eda5e4e996c1a33d2ccb870416b76d354ac
Author: Bernhard Bauer <bauerb@google.com>
Date: Thu Mar 08 12:32:36 2018

Sign in to add a comment