New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 802053 link

Starred by 1 user
Status: Fixed
Owner:
█ xlai@chromium.org
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 894021



Sign in to add a comment

Improvement of canvas webgl: Check the gpu acceleration before using CanvasResourceProvider

Project Member Reported by xlai@chromium.org, Jan 15 2018 
Currently, when HTMLCanvasElement creates image buffer (soon will be changed to CanvasResourceProvider as in https://chromium-review.googlesource.com/c/chromium/src/+/864630) for webgl rendering context, it simply uses GPU Acceleration mode without checking whether
the Gpu compositing is actually enabled at all. 

On the other hand, the implementation for canvas with 2d rendering context did a good job in having a ShouldAccelerated method. We should do the same for webgl too.
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d46ba06f6c54ca5f0865717e554421d434b0eb8

commit 5d46ba06f6c54ca5f0865717e554421d434b0eb8
Author: xlai <xlai@chromium.org>
Date: Thu May 10 20:39:51 2018

Check gpu acceleration before using CanvasResourceProvider for webgl in canvas

Bug:  802053 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I95833e58c0b7aed7244918869af159325bee75c1
Reviewed-on: https://chromium-review.googlesource.com/1050618
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557658}
[modify] https://crrev.com/5d46ba06f6c54ca5f0865717e554421d434b0eb8/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/5d46ba06f6c54ca5f0865717e554421d434b0eb8/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91777df515fb03be25dbd7c9faf1c86bb7460985

commit 91777df515fb03be25dbd7c9faf1c86bb7460985
Author: xlai <xlai@chromium.org>
Date: Fri May 11 15:59:07 2018

Remove TODO comment and add DCHECK to CanvasResourceProvider

A follow-up CL of https://chromium-review.googlesource.com/1050618.

TBR=junov@chromium.org

Bug:  802053 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I221087839763bdf3e09f642a659b7ed322f20492
Reviewed-on: https://chromium-review.googlesource.com/1055480
Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557894}
[modify] https://crrev.com/91777df515fb03be25dbd7c9faf1c86bb7460985/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc

Comment 3 by xlai@chromium.org, May 11 2018

Status: Fixed (was: Assigned)

Comment 4 by kbr@chromium.org, Oct 31

Blocking: 894021
►

Sign in to add a comment