Issue metadata
Sign in to add a comment
|
Dropdown items should be taller only if it was opened by touch
Reported by
andy.bue...@gmail.com,
Jan 15 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Example URL: http://www.ccmua.org/?page_id=1636 Steps to reproduce the problem: 1. use a HighDPI device, i can reproduce on MS Surface Pro 4 2. go to for ex. http://www.ccmua.org/?page_id=1636 3. open the "Town" dropdown What is the expected behavior? Dropdown items displayed normal What went wrong? There is very much line spacing between the dropdown items, this looks odd. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Chromium 55.0.2883.87 - Probably not the latest one, where can i download specific Chrome versions? Does this work in other browsers? Yes Chrome version: 63.0.3239.132 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 26.0 r0 In the current Chrome version the dropdown scrollbar is displayed "normal", while it was displayed too small in older versions. new.png shows the current behavior: huge line spacing and good looking scrollbar old.png shows same page with older Chrome version: normal line spacing and too small scrollbar. In older Chrome version the selection of dropdown items did not worked properly on Windows 10 Creators Fall Update, at least not in CEF. In the current Chrome version it works but it looks very odd. I have another issue with CEF, specifically CefGlue in WPF app having WinForms browser control in WindowsFormsHost which happens only on Windows 10 Creators Fall Update: Under certain conditions the keyboard does not work in text input boxes. I suspect this to be related in some kind to the other issue because it happens only on HighDPI device. Maybe this info is useful for you, otherwise just ignore.
,
Jan 16 2018
Able to reproduce the issue on reported chrome version 63.0.3239.132 and on the latest canary 65.0.3322.0 using windows 10 surface pro.
Note: Issue is not seen on Mac 10.13.1 and Ubuntu 14.04
Bisect Info:
==================
Good Build: 59.0.3067.0(463157)
Bad Build: 59.0.3068.1(463474)
You are probably looking for a change made after 463188 (known good), but no later than 463195 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/0bd89391dc79ae15c314d632f5829b0d430cf9af..5136241948671b538965c783e8aee27e88037aa9
Note: Could not provide hasbisect-per-revision as we are getting perf errors while builds are invoking.
Suspecting: https://chromium.googlesource.com/chromium/src/+/112094796a99ff35f551467912814d08935b6055
Reviewed-on: https://codereview.chromium.org/2810583002
tkent@: Please feel free to re-assign if it is not related to your change.
Thanks!
,
Jan 16 2018
Thank you for verifying this issue so fast!!! As for the mentioned keyboard error, i am actually test with different Chrome and Windows versions, probably i will open an issue for this.
,
Jan 17 2018
,
Jan 18 2018
This happens on touch-enabled devices, not HiDPI. Basically this works as intended now, however we might be able to improve behavior. e.g. Enlarge lines only if the popup is opened by touch.
,
Jan 18 2018
I cannot follow your comment or i don't understand what you say. It does not matter whether i open the dropdown on the Surface Tablet by pen, by finger or with connected USB mouse - i get always the huge space between the dropdown items with the current chrome browser version. Attached surface_59_0_3068_0__463188.png shows the same sample with Chrome version 59.0.3068.0 (463188) on Surface tablet - The space between the dropdown items looks just right for me, also the scrollbar size is fine. I would expect about the same spacing between the dropdown items on any device with any resolution and any Windows scale setting. new_pc.png shows the sample on PC with 1920x1080 resolution - It looks fine with current Chrome version on PC while on Surface tablet it looks odd. I have ordered now a non-DPI tablet with 1280x800 pixel (Surface has 2736x1824), will see how it looks there.
,
Jan 18 2018
tkent@: I think i got it now, the increased space between the dropdown items on touch devices was done because a change/feature request, maybe to make it a bit more unlikely to pick the wrong item when selecting an item with the finger? Do you plan then to add this extra space also in listboxes? It would be great if you can change it this way: - Increased spacing only when clicked with the finger (not when clicked with pen or mouse) - I can understand that it may make sense to have increased space between the items when the user uses his finger... a bit more space seems ok to me, but maybe a bit less than it is now, so it looks a bit better. - Make it also an option in the browser settings, so the user can customize this behaviour
,
Jan 21 2018
I checked this now also on device with no windows scaling needed. You are absolutely correct, it seems to happen only on touch devices. For my smell the space between the items is by far too much... if one needs so much space to pick the right item... the browser on touch devices is not really usable at all for those guys. This is just only my subjective opinion.
,
Aug 1
,
Aug 1
Issue 788109 has been merged into this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Jan 15 2018