New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802037 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Upgrade Doclava

Project Member Reported by trevordixon@chromium.org, Jan 15 2018

Issue description

Cronet uses Doclava to generate documentation for the Cronet java library. The version in use was built two years ago from AOSP branch android-6.0.1_r9. I'd like to also use Doclava (especially ApiCheck) and would prefer to start with a more recent version.

A quick test seems to show that the markup generated by this new version of Doclava isn't drastically different from what is currently generated. I attached before and after tarballs you can compare.

If it's acceptable to Cronet developers, I'd appreciate some help uploading a new version to https://pantheon.corp.google.com/storage/browser/chromium-doclava.
 
cronet_old.tar.gaz
181 KB Download
cronet_upgraded_doclava.tar.gz
181 KB Download
Any particular version you want to upgrade to?  Or just the most recent AOSP release?
Most recent AOSP release.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/buildtools/+/437a616be5b2056336ed3ca5c33c41f7788ede09

commit 437a616be5b2056336ed3ca5c33c41f7788ede09
Author: Paul Jensen <pauljensen@chromium.org>
Date: Wed Jan 17 14:53:06 2018

Roll doclava from Android version 6.0.0 to 8.1.0

Bug:  802037 
Change-Id: I2c7a5566d1b08331d5b7ca3d40c7d09347324ec9
[modify] https://crrev.com/437a616be5b2056336ed3ca5c33c41f7788ede09/android/doclava.tar.gz.sha1

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756620b98fe96b89e4b4f7ded2fb99431bd62de2

commit 756620b98fe96b89e4b4f7ded2fb99431bd62de2
Author: Paul Jensen <pauljensen@chromium.org>
Date: Thu Jan 18 17:31:03 2018

Roll buildtools to include https://crrev.com/c/chromium/buildtools/+/870670

TBR=trevordixon@chromium.org

Bug:  802037 
Change-Id: I8a914170a585e23d159e78ee7f381b473482550d
Reviewed-on: https://chromium-review.googlesource.com/873612
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530182}
[modify] https://crrev.com/756620b98fe96b89e4b4f7ded2fb99431bd62de2/DEPS

Status: Fixed (was: Untriaged)

Sign in to add a comment