New issue
Advanced search Search tips

Issue 802034 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jan 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Adaptive Toolbar: Have the named layout guide positioned on the correct button

Project Member Reported by gambard@chromium.org, Jan 15 2018 
In case there are multiple times the same button in the adaptive toolbar (for example the tab grid button is present on both toolbar), we should find a way to have the associated named layout guide moving from one button to the other, following the changes in the UI.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed

commit 6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Jan 19 16:48:07 2018

Constrain named layout guide to toolbar button

This CL adds a "guideName" property to the toolbar buttons.
This property allows the buttons to the associated named layout guide
to themselves when visible.
The constraints to the layout guide are removed when the button is
hidden. It allows the layout guide to be constrained to another button
which would become visible when this one becomes hidden.

It also adds a priority for those constraints. Having different
priorities for the different buttons allow the layout guide to be moved
from one button to the other without conflicts on the constraints.

Bug:  802034 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie4d000aed8e61c50c4981d4290d134c0fd5976e4
Reviewed-on: https://chromium-review.googlesource.com/866772
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530537}
[modify] https://crrev.com/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view_controller.mm
[modify] https://crrev.com/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed/ios/chrome/browser/ui/toolbar/clean/BUILD.gn
[modify] https://crrev.com/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed/ios/chrome/browser/ui/toolbar/clean/toolbar_button.h
[modify] https://crrev.com/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed/ios/chrome/browser/ui/toolbar/clean/toolbar_button.mm
[modify] https://crrev.com/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.h
[modify] https://crrev.com/6a1a4c19f1cb2dbaece9219fd3fbf1af778a4fed/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27b5e11f71843285ccca9f6d56dc19a358780af7

commit 27b5e11f71843285ccca9f6d56dc19a358780af7
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 24 10:36:10 2018

Add navigation history popup to adaptive toolbar

This CL adds triggers for the navigation history popup displayed when
the user long presses on the back/forward buttons.

Bug:  803373 , 802034 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie9b6f8ca7b1193fc27d52b2c91bcfabb6fb51af0
Reviewed-on: https://chromium-review.googlesource.com/878369
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531495}
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view.h
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.h
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.h
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view_controller.mm
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/clean/toolbar_button.mm
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.h
[modify] https://crrev.com/27b5e11f71843285ccca9f6d56dc19a358780af7/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a929c9e1b82fb993a6b9849a4bfae30a285af81c

commit a929c9e1b82fb993a6b9849a4bfae30a285af81c
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 31 10:00:53 2018

Clear layout guide when associated button is shown

With this CL, when a toolbar button associated with a named layout guide
is shown, all the constraints on the named layout guide are removed and
the layout guide is constrained to the toolbar button.

Bug:  802034 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I967729b7cd939fccd5821d4dfc84df8d3055e587
Reviewed-on: https://chromium-review.googlesource.com/883809
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533243}
[modify] https://crrev.com/a929c9e1b82fb993a6b9849a4bfae30a285af81c/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.h
[modify] https://crrev.com/a929c9e1b82fb993a6b9849a4bfae30a285af81c/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/a929c9e1b82fb993a6b9849a4bfae30a285af81c/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view_controller.mm
[modify] https://crrev.com/a929c9e1b82fb993a6b9849a4bfae30a285af81c/ios/chrome/browser/ui/toolbar/clean/toolbar_button.h
[modify] https://crrev.com/a929c9e1b82fb993a6b9849a4bfae30a285af81c/ios/chrome/browser/ui/toolbar/clean/toolbar_button.mm
[modify] https://crrev.com/a929c9e1b82fb993a6b9849a4bfae30a285af81c/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.h
[modify] https://crrev.com/a929c9e1b82fb993a6b9849a4bfae30a285af81c/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.mm

Comment 4 by gambard@chromium.org, Jan 31 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment