New issue
Advanced search Search tips

Issue 802023 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Blocking:
issue 798435



Sign in to add a comment

milo.Buildbot requests return with 500 Internal Server Error

Project Member Reported by perezju@chromium.org, Jan 15 2018

Issue description

Requests to the milo.Buildbot service from my scripts are returning with "HTTP Error 500: Internal Server Error".

As an example I'm trying to hit:

https://luci-milo.appspot.com/prpc/milo.Buildbot/GetBuildbotBuildJSON

with the following request:

{
    "build_num": 1921,
    "builder": "Win 10 Perf",
    "master": "chromium.perf"
}

When trying to read the contents of the response I get:

Internal Server Error. See logs.

I've also tried my request on:

https://luci-milo.appspot.com/rpcexplorer/services/milo.Buildbot/GetBuildbotBuildJSON?request={%20%20%20%20%22build_num%22:%201921,%20%20%20%20%22builder%22:%20%22Win%2010%20Perf%22,%20%20%20%20%22master%22:%20%22chromium.perf%22}

The UI responds with: "Error: Invalid response: no X-Prpc-Grpc-Code response header"
 
Blocking: 798435
Cc: no...@chromium.org
Status: Available (was: Untriaged)
Milo's Buildbot API is deprecated --- there was a [Google-internal] announcement in Sept entitled "[Action Required] Buildbot API usage for Chromium", also see https://luci-milo.appspot.com/rpcexplorer/services/. cc'ing Nodir for how best to revisit discussion.
So I should switch to milo.BuildInfo?

On which mailing list was that announcement shared? I can't seem to find that on my inbox, so I should probably subscribe to some new group ...?

Comment 4 by hinoka@chromium.org, Jan 16 2018

Mergedinto: 802307
Status: Duplicate (was: Available)
This is likely 802307

Comment 5 by no...@chromium.org, Jan 16 2018

Owner: no...@chromium.org
APIs should not be responding with HTTP 500. It is a bug. Please do not switch to BuildInfo.

Comment 6 by no...@chromium.org, Jan 16 2018

my response was rushed.

Although API is deprecated, it must continue to work because lots of clients depend on it and currently we don't have a good alternative. Please continue using it and please don't grow a dependency on BuildInfo API. The API works now: https://luci-milo.appspot.com/rpcexplorer/services/milo.Buildbot/GetBuildbotBuildJSON?request={%20%20%20%20%22build_num%22:%201921,%20%20%20%20%22builder%22:%20%22Win%2010%20Perf%22,%20%20%20%20%22master%22:%20%22chromium.perf%22}
Thanks!

Just to clarify, that means I should continue using GetBuildbotBuildJSON until a better alternative becomes available?

Comment 8 by no...@chromium.org, Jan 16 2018

yes

Sign in to add a comment