Regression : ‘Download’ option for PDF does not work when using an ‘PDF Viewer’ Extension.
Reported by
avsha...@etouch.net,
Jan 15 2018
|
|||
Issue descriptionChrome Version : 65.0.3322.0 (Official Build) 4522efba74e35026b0f62cb1c97d793a92a0d5da-refs/heads/master@{#529187} 32/64-bit OS : Mac(10.12.6, 10.13.1, 10.13.3), Windows(7,8,8.1,10), Linux(14.04 LTS) Test URL 1 : https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm/related?utm_source=chrome-ntp-icon Test URL 2 : https://msu.edu/~urban/sme865/resources/embedded_pdf.html What steps will reproduce the problem? 1. Launch chrome, open NTP, navigate to Test URL 1 and install an ‘PDF Viewer’ Extension. 2. In another tab, navigate to Test URL 2 and scroll down the page completely such that PDF file is seen. 3. On PDF toolbar, click on ‘Tools’ icon and select ‘Download’ option from the list. 4. Observe. Actual Result : ‘Download’ option on PDF toolbar does not work when using an ‘PDF Viewer’ Extension. Expected Result : ‘Download’ option for PDF should work when using an ‘PDF Viewer’ Extension. This is a regression issue broken in ‘M-65’ and using the per-revision bisect providing the bisect results, Good Build : 65.0.3309.0 (Revision : 526410) Bad Build : 65.0.3310.0 (Revision : 526575) You are probably looking for a change made after 526474 (known good), but no later than 526475 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/cbce1149c9ae08297b816effbf456c02f97df8db..f2d2fe87028de36a489f7db3f5fb28da2e9d9b2b Suspect : https://chromium.googlesource.com/chromium/src/+/f2d2fe87028de36a489f7db3f5fb28da2e9d9b2b @jochen : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : 1. Above issue is also seen on - https://pdfobject.com/ when using an ‘PDF Viewer’ Extension. 2. This issue is also observed on M-65 Dev #65.0.3315.3 build.
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68fb064d539ee2fb09d55949cebbc36d93e758aa commit 68fb064d539ee2fb09d55949cebbc36d93e758aa Author: Jochen Eisinger <jochen@chromium.org> Date: Wed Jan 17 21:56:45 2018 plumb suggested_filename through OOPIF navigations Also allow extension hosted blobs to be downloaded via top-level navigations. BUG= 802011 R=clamy@chromium.org,nasko@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4fddb82c270beb34f48153839e7189af5bb517ba Reviewed-on: https://chromium-review.googlesource.com/866972 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#529904} [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/content/browser/frame_host/navigation_handle_impl.cc [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/content/browser/frame_host/navigator.h [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/content/browser/frame_host/navigator_impl.cc [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/content/browser/frame_host/navigator_impl.h [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/content/browser/frame_host/render_frame_proxy_host.cc [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/content/browser/loader/mime_sniffing_resource_handler.cc [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/content/browser/loader/navigation_url_loader_network_service.cc [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/extensions/browser/extension_navigation_throttle.cc [modify] https://crrev.com/68fb064d539ee2fb09d55949cebbc36d93e758aa/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Jan 18 2018
,
Feb 2 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nyerramilli@chromium.org
, Jan 15 2018