New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802009 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Clipboard Events should have the default composed flag be true

Project Member Reported by kochi@chromium.org, Jan 15 2018

Issue description

Upstream issue:
https://github.com/w3c/clipboard-apis/issues/61

As of now the Clipboard API does not define the default
"composed" flag for each event (cut, copy, paste), and thus
it is treated "false" by default.

But depending on the conclusion we have to update our implementation.
 

Comment 1 Deleted

Comment 2 by kochi@chromium.org, Jan 16 2018

Cc: -kochi@chromium.org garykac@chromium.org
Owner: kochi@chromium.org

Comment 3 by kochi@chromium.org, Jan 17 2018

Blocking: 787717

Comment 4 by kochi@chromium.org, Jan 19 2018

Blocking: -787717
Now this is not blocking 787717.
Other workaround is implemented.

Comment 5 by kochi@chromium.org, Jan 19 2018

Labels: Hotlist-Interop
BTW, Blink defaults false, while WebKit defaults true.
Components: -Blink>Input Blink>DataTransfer

Comment 7 Deleted

Comment 8 by kochi@chromium.org, Feb 19 2018

The upstream issue was resolved with the spec update:
https://github.com/w3c/clipboard-apis/commit/d7eecc34bfbf9251c1a1da842e1115f49e2da2eb

Now the default "composed" flag for clipboard events is true.

Comment 9 by kochi@chromium.org, Feb 19 2018

Summary: Clipboard Events should have the default composed flag be true (was: Clipboard Events should define default composed flag)
Let me reuse this issue for updating our implementation.

Comment 10 by kochi@chromium.org, Feb 19 2018

Labels: -OS-iOS
Status: Started (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/784765ebcc3f64f83318ecfcc465c0afe7061dd6

commit 784765ebcc3f64f83318ecfcc465c0afe7061dd6
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Thu Mar 01 04:27:51 2018

Make clipboard events composed.

This corresponds to the upstream spec change on
https://github.com/w3c/clipboard-apis/pull/62

Note that synthetic events are not affected by the change.

To generate copy/cut/paste events, document.execCommand() is
used for Blink, but cannot be used for web platform tests.

Bug:  802009 
Change-Id: I00df77269708458b9a6820323a1f511b7c75e513
Reviewed-on: https://chromium-review.googlesource.com/923671
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540046}
[add] https://crrev.com/784765ebcc3f64f83318ecfcc465c0afe7061dd6/third_party/WebKit/LayoutTests/external/wpt/clipboard-apis/clipboard-events-synthetic.html
[add] https://crrev.com/784765ebcc3f64f83318ecfcc465c0afe7061dd6/third_party/WebKit/LayoutTests/fast/events/clipboard-events-composed.html
[add] https://crrev.com/784765ebcc3f64f83318ecfcc465c0afe7061dd6/third_party/WebKit/LayoutTests/fast/events/clipboard-events-synthetic.html
[modify] https://crrev.com/784765ebcc3f64f83318ecfcc465c0afe7061dd6/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/784765ebcc3f64f83318ecfcc465c0afe7061dd6/third_party/WebKit/Source/core/events/ClipboardEvent.cpp
[modify] https://crrev.com/784765ebcc3f64f83318ecfcc465c0afe7061dd6/third_party/WebKit/Source/core/events/ClipboardEvent.h

Status: Fixed (was: Started)

Sign in to add a comment