Issue metadata
Sign in to add a comment
|
site_per_process_webkit_layout_tests failing on Linux Tests (dbg)(1) |
||||||||||||||||||||
Issue descriptionSee for instance: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/69598 Unexpected Failures: * external/wpt/content-security-policy/frame-ancestors/frame-ancestors-nested-same-in-cross-url-allow.html * http/tests/misc/iframe-script-modify-attr.html
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16295fe01a1264e488dc0f7837f53e6f01e74743 commit 16295fe01a1264e488dc0f7837f53e6f01e74743 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Mar 05 22:18:14 2018 Remove test exceptions for tests that have "healed" themselves Bug: 477150, 789781 , 769508 , 661725 Bug: 611232, 745881 , 801992 Change-Id: If90fb04e97513b99716afd844a2a77ca0905ab3d Reviewed-on: https://chromium-review.googlesource.com/942316 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#540958} [modify] https://crrev.com/16295fe01a1264e488dc0f7837f53e6f01e74743/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/961c6c6cc919c92c4a8e4c51656646730c2a344c commit 961c6c6cc919c92c4a8e4c51656646730c2a344c Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Mar 12 21:24:17 2018 Triaging layout test failures from FlagExpectations/site-per-process http/tests/devtools/appcache/appcache-iframe-manifests.js: - This test was associated with crbug.com/678481 and that bug is now fixed, and the test-related expectation has already been removed from LayoutTests/TestExpectations in r527386 http/tests/media/autoplay/document-user-activation-* - These tests are flaky regardless of site-per-process and are already covered by LayoutTests/TestExpectations. This CL just extends TestExpectations entry to also cover Win. external/wpt/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html - New bug has been opened prior to this CL: https://crbug.com/819800 external/wpt/fullscreen/api/element-ready-check* - New bug has been opened prior to this CL: https://crbug.com/820617 external/wpt/css/css-fonts/font-display/font-display.html - This test is simply slow and often takes more than 5 seconds to finish - see https://crbug.com/816026#c7 - The timeout of this test is (since 2018-03-12) covered by the main LayoutTests/TestExpectations (see r542490). Other entries removed by this CL simply seem to have "healed" themselves and are currently passing on the waterfall and on the tryjobs. Bug: 477150, 794631 , 678481, 788390 Bug: 819800, 820617 , 788390 , 801992 Change-Id: If24ec321df9593ab217f50b7f1b39b3496faceef Reviewed-on: https://chromium-review.googlesource.com/957683 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542601} [modify] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process [modify] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08647d7c2c4729e9ef8e04ed4e883a2e79695c37 commit 08647d7c2c4729e9ef8e04ed4e883a2e79695c37 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Wed Mar 14 11:56:30 2018 site-per-process: Mark iframe-script-modify-attr.htm as crashing again The test is still crashing on linux_chromium_rel_ng and blocking WPT imports: * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45486 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45507 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45582 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45602 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45638 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45651 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45722 TBR=lukasza,leon.han@intel.com Bug: 801992 Change-Id: Ie51d1c04d9ed23ff7aeea1a4f3e485ab97acd3bc No-Try: true Reviewed-on: https://chromium-review.googlesource.com/962146 Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#543058} [modify] https://crrev.com/08647d7c2c4729e9ef8e04ed4e883a2e79695c37/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7663e81247c1494770dd8de1603b648a4aaeeeb commit b7663e81247c1494770dd8de1603b648a4aaeeeb Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Aug 21 18:23:30 2018 |RenderFrameHost*| shouldn't be used as a key by BlinkTestController. Addresses can be reused and therefore pointers shouldn't be used as container keys (unless the code maintaining the container can guarantee that the old entry will be destroyed before the pointer gets freed). In particular, using |RenderFrameHost*| as a key of BlinkTestController's layout_test_control_map_ was incorrect and led to timeouts described in more details in https://crbug.com/834185#c13 - #c14. This CL replaces std::map<RenderFrameHost*, ...> with std::map<std::pair<int, int>, ...> and uses (process id, frame routing id) as a key. After this CL around ~200 flaky timeouts from FlagExpectations/site-per-process seem to avoided. Before this CL, I could reliably repro a timeout in - http/tests/fetch/window/thorough/redirect-nocors-base-https-other-https.html - http/tests/fetch/serviceworker-proxied/thorough/scheme-data-base-https-other-https.html when running it 20 iterations. After this CL, I cannot repro any timeouts when running all ~200 tests 20 times: $ DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests \ -t rel --no-retry --additional-driver-flag=--site-per-process \ --iterations=20 \ --exit-after-n-failures=1 --exit-after-n-crashes-or-timeouts=1 \ --additional-driver-flag=--no-sandbox \ --additional-driver-flag=--isolate-origins=http://www.web-platform.test:8001/,http://www1.web-platform.test:8001/,http://www2.web-platform.test:8001/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8001/,http://xn--lve-6lad.web-platform.test:8001/,http://www.web-platform.test:8081/,http://www1.web-platform.test:8081/,http://www2.web-platform.test:8081/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8081/,http://xn--lve-6lad.web-platform.test:8081/,https://www.web-platform.test:8444/,https://www1.web-platform.test:8444/,https://www2.web-platform.test:8444/,https://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8444/,https://xn--lve-6lad.web-platform.test:8444/ \ --test-list=$HOME/scratch/test-list ... Found 206 tests; running 206 (20 times each: --repeat-each=1 --iterations=20), skipping 0. ... All 4120 tests ran as expected. Bug: 801992 , 834185 , 711468 , 859988 Change-Id: I9f2c1abf87027fcb3824c54e597e561ac72babb9 Reviewed-on: https://chromium-review.googlesource.com/1182316 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584841} [modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/content/shell/browser/layout_test/blink_test_controller.h [modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by raphael....@intel.com
, Jan 15 2018Status: Duplicate (was: Untriaged)