New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801989 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

hammerd-test-utils: Missing libbrillo/libmetrics dependency?

Project Member Reported by drinkcat@chromium.org, Jan 15 2018

Issue description

Found on poppy-release:

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fpoppy-release%2F1109%2F%2B%2Frecipes%2Fsteps%2FBuildPackages__afdo_use_%2F0%2Fstdout

Is hammerd-test-utils missing a dependency?

hammerd-test-utils-0.0.1-r134: >>> Configuring source in /build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2/hammerd ...
hammerd-test-utils-0.0.1-r134: /build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2/common-mk/platform2.py --libdir=/usr/lib64 --use_flags=abi_x86_64 amd64 elibc_glibc hammerd_api kernel_linux python_targets_python2_7 userland_GNU --jobs=32 --action=configure --cache_dir=/build/poppy/var/cache/portage/chromeos-base/hammerd-test-utils /build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2/hammerd/hammerd.gyp
hammerd-test-utils-0.0.1-r134: Traceback (most recent call last):
hammerd-test-utils-0.0.1-r134:   File "/build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2/common-mk/platform2.py", line 318, in <module>
hammerd-test-utils-0.0.1-r134:     main(sys.argv[1:])
hammerd-test-utils-0.0.1-r134:   File "/build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2/common-mk/platform2.py", line 314, in main
hammerd-test-utils-0.0.1-r134:     getattr(p2, options.action)(options.args)
hammerd-test-utils-0.0.1-r134:   File "/build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2/common-mk/platform2.py", line 232, in configure
hammerd-test-utils-0.0.1-r134:     cwd=self.get_platform2_root())
hammerd-test-utils-0.0.1-r134:   File "/usr/lib64/python2.7/site-packages/chromite/lib/cros_build_lib.py", line 654, in RunCommand
hammerd-test-utils-0.0.1-r134:     raise RunCommandError(msg, cmd_result)
hammerd-test-utils-0.0.1-r134: chromite.lib.cros_build_lib.RunCommandError: return code: 1; command: gyp /build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2/hammerd/hammerd.gyp '--format=ninja' '--include=/build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2/common-mk/common.gypi' '--depth=/build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2' '--toplevel-dir=/build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2' '--generator-output=/build/poppy/var/cache/portage/chromeos-base/hammerd-test-utils' '-DOS=linux' '-Dpkg-config=/build/poppy/build/bin/pkg-config' '-Dsysroot=/build/poppy' '-Dlibdir=/usr/lib64' '-Dbuild_root=/build/poppy/var/cache/portage/chromeos-base/hammerd-test-utils' '-Dplatform2_root=/build/poppy/tmp/portage/chromeos-base/hammerd-test-utils-0.0.1-r134/work/hammerd-test-utils-0.0.1/platform2' '-Dlibbase_ver=395517' '-Dclang_syntax=' '-Denable_exceptions=0' '-Dexternal_cflags=-O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables   -fno-asynchronous-unwind-tables  -clang-syntax -clang-syntax' '-Dexternal_cxxflags=-O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables   -fno-asynchronous-unwind-tables  -clang-syntax -clang-syntax' '-Dexternal_cppflags= -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE' '-Dexternal_ldflags=-Wl,-O1 -Wl,-O2 -Wl,--as-needed' '-DUSE_hammerd_api=1' '-DUSE_abi_x86_64=1' '-DUSE_amd64=1' '-DUSE_python_targets_python2_7=1' '-DUSE_kernel_linux=1' '-DUSE_elibc_glibc=1' '-DUSE_userland_GNU=1'
hammerd-test-utils-0.0.1-r134: Package libbrillo-395517 was not found in the pkg-config search path.
hammerd-test-utils-0.0.1-r134: Perhaps you should add the directory containing `libbrillo-395517.pc'
hammerd-test-utils-0.0.1-r134: to the PKG_CONFIG_PATH environment variable
hammerd-test-utils-0.0.1-r134: No package 'libbrillo-395517' found
hammerd-test-utils-0.0.1-r134: Package libmetrics-395517 was not found in the pkg-config search path.
hammerd-test-utils-0.0.1-r134: Perhaps you should add the directory containing `libmetrics-395517.pc'
hammerd-test-utils-0.0.1-r134: to the PKG_CONFIG_PATH environment variable
hammerd-test-utils-0.0.1-r134: No package 'libmetrics-395517' found
 
In theory, shouldn't hammerd-test-utils's dependencies be (hammerd dependencies) + Python?

Comment 2 by akahuang@google.com, Jan 16 2018

Yes, hammerd-test-utils should depend on hammerd. Why didn't I add it...
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a56fc85f0d63a9f80e9caa6aa770ac93345c1a70

commit a56fc85f0d63a9f80e9caa6aa770ac93345c1a70
Author: Chih-Yu Huang <akahuang@google.com>
Date: Tue Jan 16 17:24:04 2018

hammerd-test-utils: Add hammerd into dependency.

BUG= chromium:801989 
TEST=emerge-poppy -C hammerd libchrome; emerge-poppy hammerd-test-utils

Change-Id: Id4d7b0c4cfec961b4a9a0853f3f7addd94405918
Reviewed-on: https://chromium-review.googlesource.com/867144
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/a56fc85f0d63a9f80e9caa6aa770ac93345c1a70/chromeos-base/hammerd-test-utils/hammerd-test-utils-9999.ebuild

Status: Fixed (was: Assigned)

Sign in to add a comment