New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801986 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

DevTools: it's not obvious when messages are hidden due to custom levels

Reported by va...@visionsinteractive.ch, Jan 15 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3321.0 Safari/537.36

Steps to reproduce the problem:
1. Open the console
2. Call console.table with a valid parameter like ["apples", "oranges", "bananas"]

What is the expected behavior?
A rendering of the parameter value is printed in table form on the console

What went wrong?
Nothing is printed, but the return value undefined.

Did this work before? Yes unsure; probably a month ago

Chrome version: 65.0.3321.0  Channel: canary
OS Version: 10.0
Flash Version: 

Tried this in canary as well.
 
console.table-tests-2018-01-15_10-57-12.png
10.2 KB View Download

Comment 1 Deleted

Comment 2 Deleted

Delete comment ⚐
I just realized that this appears to be caused by the console filtering.

I deactivated the "Info" level and thus the rendering was hidden. If the "Info" level is activated, everything is shown as it should.

I think this hiding behavior is counter-intuitive for cases where the expression was typed on the console. 
Thus I consider this a a valid bug report, but would suggest to change its title.

Labels: Needs-Bisect Needs-Triage-M65

Comment 5 by kozy@chromium.org, Jan 15 2018

Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: sc00335...@techmahindra.com
Labels: Triaged-ET Needs-Feedback
valio@ Thanks for the issue.

Tested this issue on Windows 10, Mac OS 10.12.6 and Ubuntu14.04 using the latest Canary 65.0.3322.3 and Stable 63.0.3239.132 and below are the observations.

- On checking the Info option under Default levels in Console tab, can see the the console.table values in a table form.
- On unchecking the Info option, the console.table returns value as Undefined.
Attached are the screen shots for reference.

luoe@ Request you to kindly check this issue and confirm the correct behavior.

Thanks..
801986_with_Info.png
99 KB View Download
801986_without_Info.png
94.6 KB View Download

Comment 7 by l...@chromium.org, Jan 16 2018

Labels: -Needs-Feedback -Needs-Bisect
Summary: DevTools: it's not obvious when messages are hidden due to custom levels (was: console.table doesn't work anymore)
#c6, that looks like the intended behavior.  Console table messages are 'Info' level messages that can be hidden or shown.

It seems like the issue here was that it wasn't clear that custom levels were set in the dropdown.  There are already indicators (dropdown text changes to 'Custom levels', and 'N hidden' text appears in the toolbar) that try to make it clear.  I've updated the bug title, please let me know if you meant something different.

Let me gather some UX ideas from the team.
I am running chrome Version 64.0.3282.119 (Official Build) (64-bit)
on Windows 7.  When I run launch my html file locally under chrome, I do not see console.table output, but if I reload the page I do see console.table output.  console->info is checked ON.  Attaching an html file that I am running.
index.html
4.0 KB View Download

Comment 9 by l...@chromium.org, Feb 13 2018

@comment #8, thanks for sending the html.  DevTools does not generate table and object previews when DevTools is closed.  To see the table output, DevTools needs to be open when it is logged.
Project Member

Comment 10 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b6c2b354d23144798b4f5c4857dc29a04e2fbcf

commit 3b6c2b354d23144798b4f5c4857dc29a04e2fbcf
Author: Erik Luo <luoe@chromium.org>
Date: Wed May 23 01:53:12 2018

DevTools: give visual signal when console level filter is custom

When the console level dropdown has custom levels, it will have a
background similar to the context selector.

Screenshot: https://imgur.com/a/sKhzAzh

Bug:  801986 
Change-Id: Id015fe40ae46986bbf07455b0b5e1f0acd622afa
Reviewed-on: https://chromium-review.googlesource.com/1067854
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560884}
[modify] https://crrev.com/3b6c2b354d23144798b4f5c4857dc29a04e2fbcf/third_party/blink/renderer/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/3b6c2b354d23144798b4f5c4857dc29a04e2fbcf/third_party/blink/renderer/devtools/front_end/ui/softDropDownButton.css
[modify] https://crrev.com/3b6c2b354d23144798b4f5c4857dc29a04e2fbcf/third_party/blink/renderer/devtools/front_end/ui/toolbar.css

Comment 11 by l...@chromium.org, May 23 2018

Marking this as Fixed.
Fyi, I'm looking into making the text input filter always outlined when it is non-empty in a separate bug:  crbug.com/808159 

Comment 12 by l...@chromium.org, May 23 2018

Status: Fixed (was: Assigned)
Labels: TE-Verified-M68 TE-Verified-68.0.3439.0
Able to reproduce this issue on build without fix, hence verifying the fix on latest canary 68.0.3439.0 using Windows 10.

In build without fix not observing any color on custom level filter, As per cl in comment#10 now observing red color under custom level. Attaching screenshot for reference.

As fix is working as intended adding TE-Verified labels.

Thanks!
801986_M68.PNG
126 KB View Download

Sign in to add a comment