New issue
Advanced search Search tips

Issue 801976 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Paste-into-folder after selecting a folder by touch

Project Member Reported by yamaguchi@chromium.org, Jan 15 2018

Issue description

Chrome Version: 65.0.3323.0

Steps To Reproduce:
(1) Open a folder containing 1+ folder and 1+ regular file in the Files app.
(2) Long-tap a file
(3) Tap the three-dots button, then choose "copy"
(4) Tap a folder, then the file in this order. See only the folder remains selected.
(5) Tap the three-dots button.

Expected Result:
"Paste into folder" is available.

Actual Result:
"Paste into folder" is not shown.
 
Status: Started (was: Assigned)
This may look similar but different from  Issue 796815 .
We decided to have "Paste into folder" command only when user specifically selects a single folder, and the repro step is considered to fall into that type.

This issues happened because the event object don't have the selection info when triggering the context menu by tapping the button outside the list, as opposed to right-click on an item.
Labels: M-66

Comment 3 by sashab@chromium.org, Feb 14 2018

Owner: joelhockey@chromium.org
Status: Assigned (was: Started)
Assigning to joel to investigate for M66. :)

Comment 4 by sashab@chromium.org, Feb 16 2018

Labels: CrOS-FilesApp-Touch
<files-triage>
Cc: omrilio@chromium.org
Omri, I understand that this is your area.

I'm not sure that the existing behaviour should be changed.  Or if it should be changed, maybe it should change so that once you select 'copy', the next tap after that will deselect the items chosen to be copied.

Steps become:
1: open folder with 1+ file, 1+ folder
2: long-tap file
3: tap 3-dots, then tap 'copy'
4: tap folder.  Now only folder is selected.  The previously selected file(s) to be copied are unselected now.
5: tap 3-dots, 'Paste into folder' is available.

What do you think?
Owner: weifangsun@chromium.org
Weifang for files
Owner: joelhockey@chromium.org
Resolution from https://groups.google.com/a/google.com/d/msg/chromeos-files-app/Nh43P0b_KDM/tqoxb_OACAAJ

After long pressing a file or folder and entering check select mode, if the user navigates to the 3-dot menu and selects an action (Copy/Cut), then the check select mode should be exited allowing the user to navigate via touch to a destination for the action.


Comment 8 by sashab@chromium.org, Feb 28 2018

Status: Started (was: Assigned)

Comment 9 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Touch CrOSFilesCategory-Touch
Labels: -M-66 M-67
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e003d26c155f36e138dc23b39585cad15b31336

commit 6e003d26c155f36e138dc23b39585cad15b31336
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Apr 19 01:17:54 2018

CroS FileApp cancel check-select-mode when executing cut or copy action.

By cancelling check-select-mode after cut/copy action, any further
selection of dir/file will start a new selection rather than adding
to the existing selected files to be cut/copied.

Added support to test.html for copying files which is used
to test this feature.

Bug:  801976 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idaf851b76376ac57d03b78ae7102661e7c57a536
Reviewed-on: https://chromium-review.googlesource.com/1006744
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551907}
[modify] https://crrev.com/6e003d26c155f36e138dc23b39585cad15b31336/chrome/browser/chromeos/file_manager/file_manager_uitest.cc
[modify] https://crrev.com/6e003d26c155f36e138dc23b39585cad15b31336/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/6e003d26c155f36e138dc23b39585cad15b31336/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[add] https://crrev.com/6e003d26c155f36e138dc23b39585cad15b31336/ui/file_manager/file_manager/test/check_select.js
[modify] https://crrev.com/6e003d26c155f36e138dc23b39585cad15b31336/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js
[modify] https://crrev.com/6e003d26c155f36e138dc23b39585cad15b31336/ui/file_manager/file_manager/test/js/chrome_file_manager.js
[modify] https://crrev.com/6e003d26c155f36e138dc23b39585cad15b31336/ui/file_manager/file_manager/test/js/strings.js

Labels: Merge-Request-67
Labels: -Merge-Request-67 Merge-Rejected-67
Hi, this isn't a M67 regression and has been around for a while..For the sake of stability I'm declining.  Please retag the merge request if risk / impact outweighs.
Labels: -M-67 -Merge-Rejected-67 M-68
Status: Fixed (was: Started)

Sign in to add a comment