New issue
Advanced search Search tips

Issue 801971 link

Starred by 1 user
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jul 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 801968



Sign in to add a comment

Convert GAIAInfoUpdateService to talk to Identity Service client library

Project Member Reported by blundell@chromium.org, Jan 15 2018 
GAIAInfoUpdateService observes SigninManager to take action on signin/signout events. It also checks whether the user is signed in to gate whether an update flow is performed.

This conversion should be straightforward.

Comment 1 by blundell@chromium.org, Jan 15 2018

Components: Internals>Services>Identity
Status: Available (was: Untriaged)

Comment 2 by blundell@chromium.org, Jan 15 2018

Blocking: 801968

Comment 3 by blundell@chromium.org, Jul 12

Owner: jochen@chromium.org
Status: Assigned (was: Available)
Jochen, want to take a lookt at this?
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30e00dad74c65f02cbad9e294a8511eddb7e4346

commit 30e00dad74c65f02cbad9e294a8511eddb7e4346
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue Jul 24 14:07:52 2018

Migrate GAIAInfoUpdateService to use IdentityManager

Also change identity::ClearPrimaryAccount to work on a SigninManager,
so I can use it in tests that have a production SigninManager.

BUG= 801971 
R=blundell@chromium.org

Change-Id: I49176bd7e50a0e7c208403e276371bf93822fde6
Reviewed-on: https://chromium-review.googlesource.com/1143268
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577521}
[modify] https://crrev.com/30e00dad74c65f02cbad9e294a8511eddb7e4346/chrome/browser/profiles/gaia_info_update_service.cc
[modify] https://crrev.com/30e00dad74c65f02cbad9e294a8511eddb7e4346/chrome/browser/profiles/gaia_info_update_service.h
[modify] https://crrev.com/30e00dad74c65f02cbad9e294a8511eddb7e4346/chrome/browser/profiles/gaia_info_update_service_factory.cc
[modify] https://crrev.com/30e00dad74c65f02cbad9e294a8511eddb7e4346/chrome/browser/profiles/gaia_info_update_service_unittest.cc
[modify] https://crrev.com/30e00dad74c65f02cbad9e294a8511eddb7e4346/services/identity/public/cpp/identity_test_utils.cc
[modify] https://crrev.com/30e00dad74c65f02cbad9e294a8511eddb7e4346/services/identity/public/cpp/identity_test_utils.h

Comment 5 by jochen@chromium.org, Jul 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment