New issue
Advanced search Search tips

Issue 801967 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

clang/win: Rebuilding third_party/mesa fails

Project Member Reported by yoichio@chromium.org, Jan 15 2018

Issue description

Version: At latest ToT today:
https://chromium.googlesource.com/chromium/src/+/4522efba74e35026b0f62cb1c97d793a92a0d5da

# gn args ./
# Build arguments go here.
# See "gn args <out_dir> --list" for available build arguments.
is_component_build = true
is_debug = false
symbol_level = 0
is_clang = true
use_goma = true
is_win_fastlink = true
# use_lld = true
enable_nacl = false
dcheck_always_on = true

$ ninja -c clean third_party/mesa
$ ninja third_party/mesa
...
[3/151] CC obj/third_party/mesa/mesa/queryobj.obj
FAILED: obj/third_party/mesa/mesa/queryobj.obj
C:\goma\goma-win64/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  "-imsvcc:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\include\10.0.15063.0\um" "-imsvcc:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\include\10.0.15063.0\shared" "-imsvcc:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\include\10.0.15063.0\winrt" "-imsvcc:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\include\10.0.15063.0\ucrt" "-imsvcc:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\vc\tools\msvc\14.11.25503\include" "-imsvcc:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\vc\tools\msvc\14.11.25503\atlmfc\include" -D_GLAPI_NO_EXPORTS -D"MAPI_ABI_HEADER=\"glapi_mapi_tmp_shared.h\"" -D"PACKAGE_NAME=\"Mesa\"" -D"PACKAGE_TARNAME=\"mesa\"" -D"PACKAGE_VERSION=\"9.0.3\"" -D"PACKAGE_STRING=\"Mesa 9.0.3\"" -D"PACKAGE_BUGREPORT=\"https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa\"" -D"PACKAGE_URL=\"\"" -D"PACKAGE=\"mesa\"" -D"VERSION=\"9.0.3\"" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_DLFCN_H=1 -D"LT_OBJDIR=\".libs/\"" -DYYTEXT_POINTER=1 -DHAVE_LIBEXPAT=1 -DHAVE_LIBXCB_DRI2=1 -DFEATURE_GL=1 -DMAPI_MODE_GLAPI -DIN_DRI_DRIVER -DUSE_XCB -DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DIN_DRI_DRIVER -DHAVE_ALIAS -DHAVE_MINCORE -DHAVE_LIBUDEV -D_GLAPI_NO_EXPORTS -DYY_USE_CONST -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D"CR_CLANG_REVISION=\"321529-1\"" -D_HAS_EXCEPTIONS=0 -DCOMPONENT_BUILD -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DDEPRECATEDENUMERATOR(x)=[[deprecated(x)]] -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000000 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE
-DMESA_EGL_NO_X11_HEADERS -I../../third_party/mesa/src/src/gallium/auxiliary -I../../third_party/mesa/src/src/gallium/include -I../../third_party/mesa/src/src/glsl -I../../third_party/mesa/src/src/glsl/glcpp -I../../third_party/mesa/src/src/mapi -I../../third_party/mesa/src/src/mapi/glapi -I../../third_party/mesa/src/src/mesa -I../../third_party/mesa/src/src/mesa/main -I../../third_party/mesa/src/include -I../../third_party/mesa/src/chromium_gensrc/mesa -I../../third_party/mesa/src/chromium_gensrc/mesa/main -I../../third_party/mesa/src/chromium_gensrc/mesa/program -I../../third_party/mesa/src/chromium_gensrc/mesa/glapi -I../.. -Igen -I../../third_party/mesa/src/include -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 -m64 /O1 /Ob2 /Oy- /d2Zi+ /Zc:inline /Gw /Oi /MD -Xclang -add-plugin -Xclang find-bad-constructs /W3 /wd4800 /wd4267 /wd4996 -Wno-unused-variable /WX /utf-8 /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 -Wno-unknown-pragmas -Wno-microsoft-cast -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-constant-compare -Wtautological-constant-out-of-range-compare -Wno-tautological-constant-out-of-range-compare -Wno-mismatched-tags -Wno-unused-local-typedef -Wno-deprecated-register /wd4005 /wd4018 /wd4065
/wd4090 /wd4099 /wd4273 /wd4291 /wd4305 /wd4334 /wd4345 /wd4311 /TC /c ../../third_party/mesa/src/src/mesa/main/queryobj.c /Foobj/third_party/mesa/mesa/queryobj.obj /Fd"obj/third_party/mesa/mesa_c.pdb"
clang-cl.exe: error: no such file or directory: '9.0.3'

Building with last week tree does't reproduce:
https://chromium.googlesource.com/chromium/src/+ab528d092410f3ad5704d7212ac171ae97605c49
 
Found the culprit patch:
crrev.com/c/832593 (Do not use rsp files for windows compile)

Comment 2 by tikuta@chromium.org, Jan 16 2018

Which version of goma client do you use?
Please try in version 148.

Comment 3 by tikuta@chromium.org, Jan 16 2018

Cc: tikuta@chromium.org
Owner: yoichio@chromium.org
Cc: yyanagisawa@chromium.org
Status: Fixed (was: Untriaged)
|goma_ctrl update| got latest version and fixed it. Thanks.
However I wonder why my goma client has not updated with
|goma_ctrl restart| command...
I rethought why it did not happen and I come up with cache.

To speed up "goma_ctl.py restart", goma_ctl.py won't try to check new goma version is coming or not if it checked no new version in four hours.  You may see "Auto update is skipped because latest/MANIFEST was updated recently." when that happens.

I feel especially for this kinds of update, we should have mentioned "goma_ctl.py update" is needed.

Sign in to add a comment