New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801955 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Associate |origin| in PeerConnectionTrackerHost::GetUserMedia with RenderFrameHost

Reported by vm.ar...@samsung.com, Jan 15 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce the problem:
Associate |origin| with |RenderFrameHost| object.

What is the expected behavior?

What went wrong?
Associate |origin| with |RenderFrameHost| object

Did this work before? N/A 

Chrome version: 63.0.3239.132  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 

Comment 1 by guidou@chromium.org, Jan 15 2018

Components: Blink>WebRTC>Tools
Owner: guidou@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by guidou@chromium.org, Apr 26 2018

Labels: Needs-Feedback
What does this bug consist of?

Comment 3 by guidou@chromium.org, Jun 21 2018

Status: WontFix (was: Assigned)
Closing since it is not clear what this bug is. Please reopen if a clarification is provided.

Comment 4 by c.pa...@samsung.com, Jun 26 2018

Cc: guidou@chromium.org
Components: -Blink>WebRTC>Tools Blink>WebRTC
Labels: -OS-Windows -Needs-Feedback -Arch-x86_64 -Via-Wizard-Other
Owner: c.pa...@samsung.com
Status: Assigned (was: WontFix)
Summary: Associate |origin| in PeerConnectionTrackerHost::GetUserMedia with RenderFrameHost (was: Associate |origin| with |RenderFrameHost| object)
IIRC, this bug was created to remove passing origin as string [1] in PeerConnectionTrackerHost mojo ipc. Instead, RenderFrameHost should be used to get the origin on the browser side.
[1] https://cs.chromium.org/chromium/src/content/common/media/peer_connection_tracker.mojom?l=33

Reopening this bug. I'll take up this one.

guidou@: For a start, PeerConnectionTrackerHost has to be made per frame?

Comment 5 by guidou@chromium.org, Jun 26 2018

c.padhi@: Thanks for taking care of this. PeerConnectionTrackerHost doesn't necessarily have to be per-frame because PeerConnectionTracker and other PeerConnection classes are per renderer process, not per frame.

It's OK to make it per frame, but then the client-side PeerConnectionTracker should be made per frame as well.

Note also that passing the origin to PCTH is not a serious problem since this origin is used only for informative purposes in chrome://webrtc-internals, and not to make authorization decisions based on it.

Comment 6 by c.pa...@samsung.com, Jun 26 2018

Oh, okay. Thanks for the information though. Let's drop this bug then?

Sign in to add a comment