New issue
Advanced search Search tips

Issue 801942 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Jan 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Count of bookmarked url doesn't appear in context menu of bookmarks bar folder.

Reported by vku...@etouch.net, Jan 15 2018 
Chrome Version:65.0.3321.0 (Official Build)Revision f79b3bae327fee2d365d8e2e3a9d8b937d86608c-refs/heads/master@{#529180} (32/64-bit)
OS:Win(7,8,8.1,10)

What steps will reproduce the problem?
(1)Launch chrome and bookmark 3 to 4 webpages.
(2)Navigate to chrome://bookmarks/ , right click near "bookmark bar" folder such that context menu appear
(3)Observe the "open all bookmarks" option.

Actual: Count of bookmarked url doesn't appear in context menu of bookmarks bar folder.

Expected: Count of bookmarked url should appear in context menu of bookmarks bar foelder.

This is a regression issue broken in 'M65' and will soon provide other info.
Good build: 65.0.3316.0 (Revision: 527862).
Bad build: 65.0.3317.0 (Revision: 5281 19).
Actual_Result.png
64.3 KB View Download
Expected_Result.png
64.9 KB View Download

Comment 1 by vku...@etouch.net, Jan 15 2018

Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 527911 (known good), but no later than 527912 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/07c71f41d989e9da75e0f211dec182b545496e56..043c7cb9efab319aee82ffd0b8c97f01b67260d1

Suspecting: https://chromium.googlesource.com/chromium/src/+/043c7cb9efab319aee82ffd0b8c97f01b67260d1

@calamity: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is seen on Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS) OS as well.

Comment 2 by nyerramilli@chromium.org, Jan 15 2018

Labels: RegressedIn-65 Target-65 FoundIn-65

Comment 3 by nyerramilli@chromium.org, Jan 16 2018 

marking as RBS please change if required.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/430ef000a006a15ec62332207487378ddb7248b4

commit 430ef000a006a15ec62332207487378ddb7248b4
Author: Christopher Lam <calamity@chromium.org>
Date: Thu Jan 18 10:08:50 2018

[MD Bookmarks] Fix sublabels in context menu.

This CL fixes a bug introduced when the command manager was refactored
that makes sublabels never show.

Bug:  801942 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2d309e068755686ac6e58d68f60636ad32e3addd
Reviewed-on: https://chromium-review.googlesource.com/872630
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530106}
[modify] https://crrev.com/430ef000a006a15ec62332207487378ddb7248b4/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/430ef000a006a15ec62332207487378ddb7248b4/chrome/test/data/webui/md_bookmarks/command_manager_test.js

Comment 5 by rbasuvula@chromium.org, Jan 18 2018

Labels: ReleaseBlock-Stable

Comment 6 by calamity@chromium.org, Jan 18 2018

Status: Fixed (was: Assigned)
Project Member

Comment 7 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Jan 18 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Comment 8 by gov...@chromium.org, Jan 19 2018

Labels: -Merge-TBD
M65 is branched at 3325, chromium revision 530369. CL listed at #4 is already in branch. No merge is needed here.

Comment 9 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported
►

Sign in to add a comment