Step (1) now needs chrome://flags/#enable-desktop-pwas-link-capturing. Not going to be turned on in M67 so punting.

Adding this to M-67. Link capturing is a side-effect of the fact that we consider all sites with a manifest to be PWAs.

Bumping to P2 because it may break if we make this change later. (Since we will be adding properties to already-installed bookmark apps in 67 and then removing those properties later.)

Pushing back to P3 (this is less urgent than the other P2s).

67 has branched, moving bugs over to 68.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36603cc6e3d2d788c133ba709701affa2072e22d

commit 36603cc6e3d2d788c133ba709701affa2072e22d
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Apr 13 03:43:53 2018

desktop-pwas: Only add a scope for installable sites i.e. PWAs

Also changes Installable to an enum class to avoid accidental
implicit casts to bools.

Bug:  801940 
Change-Id: I186d878b338375e339b3b5eb24fa5f2abd6c975a
Reviewed-on: https://chromium-review.googlesource.com/981835
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550502}
[modify] https://crrev.com/36603cc6e3d2d788c133ba709701affa2072e22d/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/36603cc6e3d2d788c133ba709701affa2072e22d/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/36603cc6e3d2d788c133ba709701affa2072e22d/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/36603cc6e3d2d788c133ba709701affa2072e22d/chrome/browser/extensions/favicon_downloader.h

This didn't make it into branch.

CL is +145,-165 so might be difficult to merge. Gio, what do you think? I don't fully understand why this is necessary without link capturing (despite #3). Can you explain?

PWAs differ from regular Bookmark Apps in the following user-visible ways:

1. There is a Context Menu item to open links in PWA windows for in-scope links.
2. Clients.openWindow() opens a new window rather than a tab
3. Out-of-scope navigations open new tab
4. Popups don't inherit the apps theme
5. Mixed content is blocked

On the code side, many of our methods include "PWA". If we don't merge this, those methods will be slightly less accurate.

The fact that this is not part of the launch might cause confusion when we stop doing this in the next release.

The patch is big, but the actual changes to release code are small: a rename of an enum and the addition of an if statement. I think we should try to merge.

OK that makes sense. Number 1, 2 and 3 are significant changes that will break expectations when they get reverted in 68. So I am in favour of merging this.

Canary isn't updated yet. Will wait.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36603cc6e3d2d788c133ba709701affa2072e22d

commit 36603cc6e3d2d788c133ba709701affa2072e22d
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Apr 13 03:43:53 2018

desktop-pwas: Only add a scope for installable sites i.e. PWAs

Also changes Installable to an enum class to avoid accidental
implicit casts to bools.

Bug:  801940 
Change-Id: I186d878b338375e339b3b5eb24fa5f2abd6c975a
Reviewed-on: https://chromium-review.googlesource.com/981835
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550502}
[modify] https://crrev.com/36603cc6e3d2d788c133ba709701affa2072e22d/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/36603cc6e3d2d788c133ba709701affa2072e22d/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/36603cc6e3d2d788c133ba709701affa2072e22d/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/36603cc6e3d2d788c133ba709701affa2072e22d/chrome/browser/extensions/favicon_downloader.h

Verified on 68.0.3397.0

Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Dev/Beta Release. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf2359a6711e8c5fdeaafcc29bbdc1d623ec6e29

commit bf2359a6711e8c5fdeaafcc29bbdc1d623ec6e29
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Apr 20 23:34:04 2018

desktop-pwas: Only add a scope for installable sites i.e. PWAs

Also changes Installable to an enum class to avoid accidental
implicit casts to bools.

Bug:  801940 
Change-Id: I186d878b338375e339b3b5eb24fa5f2abd6c975a
Reviewed-on: https://chromium-review.googlesource.com/981835
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550502}(cherry picked from commit 36603cc6e3d2d788c133ba709701affa2072e22d)
Reviewed-on: https://chromium-review.googlesource.com/1023130
Cr-Commit-Position: refs/branch-heads/3396@{#186}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/bf2359a6711e8c5fdeaafcc29bbdc1d623ec6e29/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/bf2359a6711e8c5fdeaafcc29bbdc1d623ec6e29/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/bf2359a6711e8c5fdeaafcc29bbdc1d623ec6e29/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/bf2359a6711e8c5fdeaafcc29bbdc1d623ec6e29/chrome/browser/extensions/favicon_downloader.h