update_kernel fails with ipv6 addresses |
||
Issue description./update_kernel.sh --remote="fe80::yaddayadda%eth0" INFO : Target reports arch is x86_64 INFO : Target reports root device is /dev/mmcblk1p INFO : System is not using verity: updating firmware and modules copying kernel updating syslinux kernel copying modules ssh: Could not resolve hostname fe80: Name or service not known lost connection Looks like something's not wrapped properly for the ipv6 address.
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/57bf27f7d212e4ff958d6716491c11e7c713ad6d commit 57bf27f7d212e4ff958d6716491c11e7c713ad6d Author: Benson Leung <bleung@chromium.org> Date: Mon Jan 15 20:02:34 2018 remote_access.sh: enclose IPv6 address with brackets for scp Looks like there was one other place where special syntax is needed when working with ipv6 addresses. Reuses the same brackets_enclosed_if_ipv6() used for rsync in remote_cp_to, which uses scp. Ref to crosreview.com/277390, which originally added this functionality. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:801933 TEST=./update_kernel.sh --remote="<ipv6 link local addr>" Does not fail. Succeeds. Change-Id: Icaaf9af7e43c249c317fac9d4824c98630a72488 Reviewed-on: https://chromium-review.googlesource.com/865967 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/57bf27f7d212e4ff958d6716491c11e7c713ad6d/remote_access.sh
,
Jan 18 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bleung@chromium.org
, Jan 15 2018