New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801910 link

Starred by 2 users
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Aug 21
Cc:
█ mkwst@chromium.org
morlovich@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 856777



Sign in to add a comment

Enhance Chrome Cookie Logging

Project Member Reported by rdsmith@chromium.org, Jan 14 2018 
There are occasionally bugs filed against Chrome that come down to cookies either existing where they shouldn't (session cookies after a restart) or not existing where they should (e.g. login cookies expected to persist over a shutdown as noted in issues  795827  and  794453 ).  The network stack has no logging that I can see in either cookie_monster.cc (the default in-memory cookie store) or sqlite_persistent_cookie_store.cc (the on-disk persistent cookie store).  There should be enough logging in those two areas that a netlog dump could be used to help debug problems like the ones described above.  

This logging should specifically be able to indicate when cookies are added or deleted, and by what user initiated mechanism (web page visit, shutdown, startup, browsing data remover, eviction).

Obviously, this logging should only be done if the "include cookies and credentials" box is checked for netlog capture.

+mkwst@ FHI.

Comment 1 by mmenke@chromium.org, Jan 16 2018 

Could imagine logging more general information when cookie logging is disabled (Like "Cookie discarded because <secure cookie already exists | it's a Friday and I'm feeling lazy | etc>").

Also, cookies are also garbage collected (It's mostly relevant here when a new cookie evicts an old cookie for the same site, as opposed to evicting cookies for other sites - which only happens for cookies set over 30 days ago, I believe).  Are you thinking of logging that, too?

Comment 2 by rdsmith@chromium.org, Jan 16 2018 

Re: Garbage collection.  Yep, I think we sorta have to if we're targeting the types of problems described.

Comment 3 by rdsmith@chromium.org, Feb 2 2018

Labels: Postmortem-Followup

Comment 4 by mmenke@chromium.org, Feb 28 2018

Labels: Network-Triaged
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b78e0928ee88da3ceda0466d018d33ce9d98e91a

commit b78e0928ee88da3ceda0466d018d33ce9d98e91a
Author: Randy Smith <rdsmith@chromium.org>
Date: Thu Mar 01 21:19:54 2018

Add NetLogging to CookieMonster.

Bug:  801910 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I96e376a2852410e53005ce51bf5f6485776b26a6
Reviewed-on: https://chromium-review.googlesource.com/925181
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540288}
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/components/safe_browsing/browser/safe_browsing_url_request_context_getter.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/content/browser/BUILD.gn
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/content/browser/net/quota_policy_cookie_store.h
[add] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/content/browser/net/quota_policy_cookie_store_netlog_params.cc
[add] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/content/browser/net/quota_policy_cookie_store_netlog_params.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/content/browser/net/quota_policy_cookie_store_unittest.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/content/public/browser/cookie_store_factory.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/chrome/browser/net/cookie_util.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/net/cookies/cookie_store_ios_persistent.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/net/cookies/cookie_store_ios_persistent.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/net/cookies/cookie_store_ios_persistent_unittest.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/net/cookies/cookie_store_ios_test_util.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/net/cookies/cookie_store_ios_test_util.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/web/shell/shell_url_request_context_getter.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/ios/web_view/internal/web_view_url_request_context_getter.mm
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/BUILD.gn
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_change_dispatcher.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_change_dispatcher.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_constants.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_constants.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_monster.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_monster.h
[add] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_monster_netlog_params.cc
[add] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_monster_netlog_params.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_monster_perftest.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_monster_store_test.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/extras/sqlite/sqlite_persistent_cookie_store.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/log/net_log_event_type_list.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/log/net_log_source_type_list.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/url_request/url_request_netlog_params.h
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/net/url_request/url_request_test_util.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/services/network/cookie_manager_unittest.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/services/network/network_context.cc
[modify] https://crrev.com/b78e0928ee88da3ceda0466d018d33ce9d98e91a/services/network/restricted_cookie_manager_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a03bbe5dd7aa60f65b3db57590e103baa3111a7

commit 1a03bbe5dd7aa60f65b3db57590e103baa3111a7
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Fri Mar 02 19:05:47 2018

Revert "Add NetLogging to CookieMonster."

This reverts commit b78e0928ee88da3ceda0466d018d33ce9d98e91a.

Reason for revert: Causes extreme flakiness on headless_browsertests:
https://ci.chromium.org/buildbot/chromium.fyi/Headless%20Linux%20%28dbg%29/?limit=200
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)

Failing test:
[ RUN      ] HeadlessBrowserTest.UserDataDir
[32213:32213:0301/143738.704696:555470268:WARNING:resource_bundle.cc(349)] locale_file_path.empty() for locale
[0301/143739.059306:WARNING:resource_bundle.cc(349)] locale_file_path.empty() for locale
[32213:32213:0301/143739.079820:555845388:ERROR:gpu_process_transport_factory.cc(1007)] Lost UI shared context.
[32213:32230:0301/143739.097953:555863521:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file natives_blob.bin
[32213:32230:0301/143739.098046:555863609:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file snapshot_blob.bin
Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf
[32213:32220:0301/143739.424162:556189730:FATAL:lock_impl_posix.cc(76)] Check failed: rv == 0 (22 vs. 0). Invalid argument
#0 0x7fcd600bf6ad base::debug::StackTrace::StackTrace()
#1 0x7fcd600bdb9c base::debug::StackTrace::StackTrace()
#2 0x7fcd60145bca logging::LogMessage::~LogMessage()
#3 0x7fcd602858a3 base::internal::LockImpl::Lock()
#4 0x7fcd5dfa6f43 base::Lock::Acquire()
#5 0x7fcd5dfa55c3 base::AutoLock::AutoLock()
#6 0x7fcd5e0ca02b net::NetLog::AddEntry()
#7 0x7fcd5e0d38b4 net::NetLogWithSource::AddEntry()
#8 0x7fcd5e0d3917 net::NetLogWithSource::AddEvent()
#9 0x7fcd5a244bca content::QuotaPolicyCookieStore::Close()
#10 0x7fcd5e2226ff net::CookieMonster::~CookieMonster()
#11 0x7fcd5e223069 net::CookieMonster::~CookieMonster()
#12 0x7fcd5ea1b70b net::URLRequestContextStorage::~URLRequestContextStorage()
#13 0x7fcd5ea18271 net::(anonymous namespace)::ContainerURLRequestContext::~ContainerURLRequestContext()
#14 0x7fcd5ea182a9 net::(anonymous namespace)::ContainerURLRequestContext::~ContainerURLRequestContext()
#15 0x7fcd5f5a050b headless::HeadlessURLRequestContextGetter::NotifyContextShuttingDown()
#16 0x7fcd5f547faf _ZN4base8internal13FunctorTraitsIMN8headless31HeadlessURLRequestContextGetterEFvvEvE6InvokeI13scoped_refptrIS3_EJEEEvS5_OT_DpOT0_
#17 0x7fcd5f547ef4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN8headless31HeadlessURLRequestContextGetterEFvvEJ13scoped_refptrIS5_EEEEvOT_DpOT0_
#18 0x7fcd5f547ea0 _ZN4base8internal7InvokerINS0_9BindStateIMN8headless31HeadlessURLRequestContextGetterEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#19 0x7fcd5f547dc9 _ZN4base8internal7InvokerINS0_9BindStateIMN8headless31HeadlessURLRequestContextGetterEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#20 0x7fcd6006e1b1 _ZNO4base12OnceCallbackIFvvEE3RunEv
#21 0x7fcd600c35ef base::debug::TaskAnnotator::RunTask()
#22 0x7fcd601622e9 base::internal::IncomingTaskQueue::RunTask()
#23 0x7fcd6016b6ab base::MessageLoop::RunTask()
#24 0x7fcd6016b948 base::MessageLoop::DeferOrRunPendingTask()
#25 0x7fcd6016bc58 base::MessageLoop::DoWork()
#26 0x7fcd6016fc31 base::MessagePumpLibevent::Run()
#27 0x7fcd6016ae6c base::MessageLoop::Run()
#28 0x7fcd6022066d base::RunLoop::Run()
#29 0x7fcd602de5b8 base::Thread::Run()
#30 0x7fcd59a60d86 content::BrowserThreadImpl::IOThreadRun()
#31 0x7fcd59a6101f content::BrowserThreadImpl::Run()
#32 0x7fcd602df225 base::Thread::ThreadMain()
#33 0x7fcd602d526d base::(anonymous namespace)::ThreadFunc()
#34 0x7fcd6046b184 start_thread
#35 0x7fcd4b76503d clone
[0301/143739.572502:WARNING:resource_bundle.cc(349)] locale_file_path.empty() for locale

Original change's description:
> Add NetLogging to CookieMonster.
> 
> Bug:  801910 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I96e376a2852410e53005ce51bf5f6485776b26a6
> Reviewed-on: https://chromium-review.googlesource.com/925181
> Commit-Queue: Randy Smith <rdsmith@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540288}

TBR=rohitrao@chromium.org,rdsmith@chromium.org,jam@chromium.org,torne@chromium.org,reillyg@chromium.org,mmenke@chromium.org

Change-Id: I10a15e59dc26e5c9865282e95f164fed7410298f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  801910 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/946708
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540576}
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/components/safe_browsing/browser/safe_browsing_url_request_context_getter.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/content/browser/BUILD.gn
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/content/browser/net/quota_policy_cookie_store.h
[delete] https://crrev.com/0dc5bdc371491ebfedb29f30e06c706d4db09cd6/content/browser/net/quota_policy_cookie_store_netlog_params.cc
[delete] https://crrev.com/0dc5bdc371491ebfedb29f30e06c706d4db09cd6/content/browser/net/quota_policy_cookie_store_netlog_params.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/content/browser/net/quota_policy_cookie_store_unittest.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/content/public/browser/cookie_store_factory.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/chrome/browser/net/cookie_util.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/net/cookies/cookie_store_ios_persistent.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/net/cookies/cookie_store_ios_persistent.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/net/cookies/cookie_store_ios_persistent_unittest.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/net/cookies/cookie_store_ios_test_util.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/net/cookies/cookie_store_ios_test_util.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/web/shell/shell_url_request_context_getter.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/ios/web_view/internal/web_view_url_request_context_getter.mm
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/BUILD.gn
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_change_dispatcher.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_change_dispatcher.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_constants.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_constants.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_monster.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_monster.h
[delete] https://crrev.com/0dc5bdc371491ebfedb29f30e06c706d4db09cd6/net/cookies/cookie_monster_netlog_params.cc
[delete] https://crrev.com/0dc5bdc371491ebfedb29f30e06c706d4db09cd6/net/cookies/cookie_monster_netlog_params.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_monster_perftest.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_monster_store_test.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/extras/sqlite/sqlite_persistent_cookie_store.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/log/net_log_event_type_list.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/log/net_log_source_type_list.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/url_request/url_request_netlog_params.h
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/net/url_request/url_request_test_util.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/services/network/cookie_manager_unittest.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/services/network/network_context.cc
[modify] https://crrev.com/1a03bbe5dd7aa60f65b3db57590e103baa3111a7/services/network/restricted_cookie_manager_unittest.cc

Comment 7 by kariahda@chromium.org, May 21 2018 

Bulk edit**

This bug has the label Postmortem-Followup but has not been updated in 3+ weeks. We are working on a new workflow to improve postmortem followthrough. Postmortems and postmortem bugs are very important in making sure we don't repeat prior mistakes and for making Chrome better for all.

We will be taking a closer look at these bugs in the coming weeks. Please take some time to work on this, reassign, or close if the issue has been fixed. Thank you.

Comment 8 by xunji...@chromium.org, Aug 10

Blocking: 856777
Cc: mmenke@chromium.org
Owner: xunji...@chromium.org
Status: Started (was: Available)
Matt told me that having visibility in Cookies blocking in NetLog is very helpful. I will see if I can get Randy's CL relanded.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf

commit cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf
Author: Helen Li <xunjieli@chromium.org>
Date: Mon Aug 13 16:07:53 2018

Add NetLog event logging to cookie_monster.cc

This CL is split off rdsmith@'s CL at
https://chromium-review.googlesource.com/c/chromium/src/+/925181

This CL only adds the logging code for events, but uses a null NetLog.
A followup CL will modify the CookieStore constructor to pass in a non-null
NetLog.

Bug:  801910 
Change-Id: Icd40aa206055c82a4e84ddb66c8547b69ec662ff
Reviewed-on: https://chromium-review.googlesource.com/1170594
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582603}
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/BUILD.gn
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/cookies/cookie_change_dispatcher.cc
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/cookies/cookie_change_dispatcher.h
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/cookies/cookie_constants.cc
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/cookies/cookie_constants.h
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/cookies/cookie_monster.cc
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/cookies/cookie_monster.h
[add] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/cookies/cookie_monster_netlog_params.cc
[add] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/cookies/cookie_monster_netlog_params.h
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/log/net_log_event_type_list.h
[modify] https://crrev.com/cd0fab8679a62e3c43106b2f6b351e5e1c2bfbcf/net/log/net_log_source_type_list.h
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb313a9194643d289364d499c76680064f7a1f73

commit fb313a9194643d289364d499c76680064f7a1f73
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Aug 14 15:46:44 2018

Modify CookieMonster's constructors to pass in a NetLog*

This CL adds a NetLog* parameter to CookieMonster's constructors, so we can use
it to log NetLog events that are related to setting cookies.

This CL is split off from rdsmith@'s CL at
https://chromium-review.googlesource.com/c/chromium/src/+/925181

Left TODOs to hook up headless and iOS. I will upload followup CLs to address
those.

TBR=pfeldman@chromium.org
TBR=slan@chromium.org

Bug:  801910 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibd76217b45326e1763263cdda391d9d584c458bf
Reviewed-on: https://chromium-review.googlesource.com/1171113
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582923}
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/components/safe_browsing/browser/safe_browsing_url_request_context_getter.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/content/public/browser/cookie_store_factory.h
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/ios/components/io_thread/ios_io_thread.mm
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/cookies/cookie_monster.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/cookies/cookie_monster.h
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/cookies/cookie_monster_perftest.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/net/url_request/url_request_test_util.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/services/network/cookie_manager_unittest.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/services/network/network_context.cc
[modify] https://crrev.com/fb313a9194643d289364d499c76680064f7a1f73/services/network/restricted_cookie_manager_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edd838a5690a6be24f57c29931bc61f9d025d99a

commit edd838a5690a6be24f57c29931bc61f9d025d99a
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Aug 14 23:27:29 2018

Remove unused SqlitePersistentCookieStore::Close()

This CL removes unused SqlitePersistentCookieStore::Close().

Bug:  801910 
Change-Id: Ibba90aaeb5c07215de73e85f33bb5c4067cf9f42
Reviewed-on: https://chromium-review.googlesource.com/1174948
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583077}
[modify] https://crrev.com/edd838a5690a6be24f57c29931bc61f9d025d99a/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/edd838a5690a6be24f57c29931bc61f9d025d99a/net/extras/sqlite/sqlite_persistent_cookie_store.h
[modify] https://crrev.com/edd838a5690a6be24f57c29931bc61f9d025d99a/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a29f10edcffee5507b501f8bb9d0d767879c82

commit 92a29f10edcffee5507b501f8bb9d0d767879c82
Author: Helen Li <xunjieli@chromium.org>
Date: Wed Aug 15 23:02:26 2018

Add NetLog events to SQLitePersistentCookieStore

This CL adds NetLog events to SQLitePersistentCookieStore.

This is split off from rdsmith@'s CL at
https://chromium-review.googlesource.com/c/chromium/src/+/925181

TBR=marq@chromium.org

Bug:  801910 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6404a341bbebbd19078b834a483804f4b8468447
Reviewed-on: https://chromium-review.googlesource.com/1174570
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583430}
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/content/browser/net/quota_policy_cookie_store_unittest.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/ios/net/cookies/cookie_store_ios_test_util.h
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/ios/net/cookies/cookie_store_ios_test_util.mm
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/cookies/cookie_monster.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/cookies/cookie_monster.h
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/cookies/cookie_monster_store_test.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/cookies/cookie_monster_store_test.h
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/cookies/cookie_store_test_helpers.h
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/extras/sqlite/sqlite_persistent_cookie_store.h
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/net/log/net_log_event_type_list.h
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/services/network/session_cleanup_cookie_store.cc
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/services/network/session_cleanup_cookie_store.h
[modify] https://crrev.com/92a29f10edcffee5507b501f8bb9d0d767879c82/services/network/session_cleanup_cookie_store_unittest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75dbc208e189edbac4dc2d4396458ae0e5558de8

commit 75dbc208e189edbac4dc2d4396458ae0e5558de8
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Aug 16 17:12:31 2018

Add NetLog events to SessionCleanupCookieStore

This CL adds NetLog events to SessionCleanupCookieStore.

This is based on rdsmith@'s CL at
https://chromium-review.googlesource.com/c/chromium/src/+/925181

Bug:  801910 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I87a89ff265d703792a492f93ce59cb57f9f02d14
Reviewed-on: https://chromium-review.googlesource.com/1175437
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583704}
[modify] https://crrev.com/75dbc208e189edbac4dc2d4396458ae0e5558de8/net/log/net_log_event_type_list.h
[modify] https://crrev.com/75dbc208e189edbac4dc2d4396458ae0e5558de8/services/network/session_cleanup_cookie_store.cc
[modify] https://crrev.com/75dbc208e189edbac4dc2d4396458ae0e5558de8/services/network/session_cleanup_cookie_store.h
[modify] https://crrev.com/75dbc208e189edbac4dc2d4396458ae0e5558de8/services/network/session_cleanup_cookie_store_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9

commit 4e4cb0d07af0e82c2da6ec03864bcdc633626ae9
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Aug 21 14:50:47 2018

Hook up NetLog for CookieStore on iOS

This is to help with investigating cookies bugs.

This is based on rdsmith@'s CL at
https://chromium-review.googlesource.com/c/chromium/src/+/925181

Bug:  801910 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia0fbfca17a8a8ad76cbcc4e1ae46330b3f706ea0
Reviewed-on: https://chromium-review.googlesource.com/1175921
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584737}
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/chrome/browser/net/cookie_util.h
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/chrome/browser/net/cookie_util_unittest.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/net/cookies/cookie_store_ios_persistent.h
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/net/cookies/cookie_store_ios_persistent.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/net/cookies/cookie_store_ios_persistent_unittest.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/net/cookies/cookie_store_ios_unittest.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/web/shell/shell_url_request_context_getter.mm
[modify] https://crrev.com/4e4cb0d07af0e82c2da6ec03864bcdc633626ae9/ios/web_view/internal/web_view_url_request_context_getter.mm

Comment 15 by xunji...@chromium.org, Aug 21

Cc: morlovich@chromium.org
Status: Fixed (was: Started)
I worked with morlovich@ and relanded rdsmith@'s CL.
I am marking this one as Fixed. Bug 856777 tracks the bigger goal.
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1579fe6a7639df98561082ff2e3371fe44b39e21

commit 1579fe6a7639df98561082ff2e3371fe44b39e21
Author: Helen Li <xunjieli@google.com>
Date: Thu Aug 23 19:27:28 2018
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7c8be3c076d5e37b8a4155a5256ac4cb162f7c

commit 8c7c8be3c076d5e37b8a4155a5256ac4cb162f7c
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Aug 24 13:59:40 2018

Remove CookieStoreIOS unused constructor

The internal chrome_signin_cookie_manager.mm is converted to the constructor
with NetLog. The constructor with one param is now unused. This CL removes it.

Bug:  801910 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icf1ff6df91a37b6f914e60f29ac6757760cb7a2a
Reviewed-on: https://chromium-review.googlesource.com/1187387
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585828}
[modify] https://crrev.com/8c7c8be3c076d5e37b8a4155a5256ac4cb162f7c/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/8c7c8be3c076d5e37b8a4155a5256ac4cb162f7c/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/8c7c8be3c076d5e37b8a4155a5256ac4cb162f7c/ios/net/cookies/cookie_store_ios.mm
►

Sign in to add a comment