New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801884 link

Starred by 10 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Apr 2018
Cc:
tbansal@chromium.org
█ z...@chromium.org
jmukthavaram@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[2036:2036:0113/161356.666612:ERROR:network_metrics_provider.cc(391)] NOTREACHED() hit. [Reason: info:NOTREACHED()]

Reported by ja...@belchamber.com, Jan 14 2018 
UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10032.86.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.140 Safari/537.36
Platform: 10032.86.0 (Official Build) stable-channel eve

Example URL:

Steps to reproduce the problem:
"This always constitutes a coding error. Please report a bug!"

What is the expected behavior?

What went wrong?
Reporting at request of Google's Log Analyser while debugging another issue. I don't know what this issue is or what effect it's having on the end-user, happy to test and provide information where it's helpful.

Did this work before? N/A 

Chrome version: 63.0.3239.140  Channel: stable
OS Version: 10032.86.0
Flash Version: 28.0.0.137

Comment 1 by rdsmith@chromium.org, Jan 15 2018

Components: -Internals>Network Internals>Metrics
By my quick evaluation this is a crash in components/metrics/net/network_metrics_provider.cc @ https://cs.chromium.org/chromium/src/components/metrics/net/network_metrics_provider.cc?q=NetworkMetricsProvider::WriteWifiAccessPointProto&sq=package:chromium&l=410 (the line number is different because I'm pointing at the NOTREACHED() in ToT) due to an element in the OUI (?) list not being a hexadecimal number.  Officially this is metrics code and the people who have touched that file are not primarily network people, so adding that label and removing Internals>Network.  But feel free to toss it back or ping me if you thing that lateralling was in error.

Comment 2 by ja...@belchamber.com, Jan 15 2018 

I made a poorly educated guess on the component label, thanks for correcting it :)

Comment 3 by asvitk...@chromium.org, Jan 15 2018

Owner: z...@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to zqiu@ who added the code in question.

Comment 4 by asvitk...@chromium.org, Jan 15 2018

Cc: jmukthavaram@chromium.org tbansal@chromium.org
 Issue 782488  has been merged into this issue.

Comment 5 by rdsmith@chromium.org, Jan 15 2018 

@james: No worries at all, that's reasonable bug triage in action :-}.

Comment 6 by josh@arreya.com, Feb 26 2018 

Also encountering this, device log attached.

Google Chrome Version	
64.0.3282.144

Platform Version	
10176.68.0 (Official Build) stable-channel veyron_mickey

Firmware Version	
Google_Veyron_Mickey.6588.264.0
logs_20180222-0410.zip
1.4 MB Download

Comment 7 by tbansal@chromium.org, Apr 30 2018 

 Issue 837239  has been merged into this issue.

Comment 8 by tbansal@chromium.org, Apr 30 2018 

Issue 636015 has been merged into this issue.

Comment 9 by tbansal@chromium.org, Apr 30 2018

Cc: z...@chromium.org
Owner: tbansal@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9159c056962a7b7050e1c2b0d8c2a0604ea269

commit 2b9159c056962a7b7050e1c2b0d8c2a0604ea269
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Apr 30 21:48:55 2018

Replace DCHECK by DEBUG warning in NetworkMetricsProvider.

This code is quite old, affects only ChromeOS,
we really do not know who is the actual owner of this code,
or how these metrics are being used.

Change-Id: Iac7f8c24f37aa10e2f5053e0e2c734fa6220f745
Bug:  801884 
Reviewed-on: https://chromium-review.googlesource.com/1034455
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554891}
[modify] https://crrev.com/2b9159c056962a7b7050e1c2b0d8c2a0604ea269/components/metrics/net/network_metrics_provider.cc

Comment 11 by tbansal@chromium.org, Apr 30 2018

Labels: M-68
Status: Fixed (was: Started)

Comment 12 by mp...@benbria.ca, May 3 2018 

More samples of this crash.

What is the byproduct of this crash? What happens to the device when this crash occurs?
debug-logs_20180503-083623
1.6 MB View Download

Comment 13 by tbansal@chromium.org, May 4 2018 

Re #12: There is no other byproduct that I know of.

Comment 14 by mp...@benbria.ca, May 4 2018 

This doesn't cause the device to restart?

Comment 15 by corina.w...@gmail.com, May 5 2018 

It hasn't caused a device restart for me, but this error has been constant on the 6-10 chromebooks I have used with numerous google accounts for at the VERY least 2 years.  Happy to provide additional logs if you wish.  I will provide anything you want.  Pls let me know.

Comment 16 by tbansal@chromium.org, May 7 2018 

Thanks, this should be fixed for M-68.
►

Sign in to add a comment