New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801878 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug


Participants' hotlists:
Hotlist-OffHeapWasm


Sign in to add a comment

Data race in v8::internal::wasm::NativeModule::NativeModule

Project Member Reported by ClusterFuzz, Jan 14 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5406410577018880

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 8
Crash Address: 0x7fb62488df38
Crash State:
  v8::internal::wasm::NativeModule::NativeModule
  v8::internal::wasm::WasmCodeManager::NewNativeModule
  v8::internal::wasm::WasmCodeManager::NewNativeModule
  
Sanitizer: thread (TSAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5406410577018880

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: brajkumar@chromium.org
Components: Blink>JavaScript
Labels: M-64 Test-Predator-Wrong CF-NeedsTriage
V8 issue, adding appropriate label for further triage.

Thanks!
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Owner: mstarzinger@chromium.org
Status: Assigned (was: Untriaged)
Most likely related to off-heap WebAssembly code.
Labels: -CF-NeedsTriage
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3b7f2738532a58cdb7278c7eaabdd24985e6956c

commit 3b7f2738532a58cdb7278c7eaabdd24985e6956c
Author: Michael Starzinger <mstarzinger@chromium.org>
Date: Wed Jan 24 14:31:17 2018

[wasm] Fix race when assigning {NativeModule} ids.

R=clemensh@chromium.org
BUG= chromium:801878 

Change-Id: I32a3cf3a63dfe073a06066f1db2fb32eb739f153
Reviewed-on: https://chromium-review.googlesource.com/883367
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50836}
[modify] https://crrev.com/3b7f2738532a58cdb7278c7eaabdd24985e6956c/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/3b7f2738532a58cdb7278c7eaabdd24985e6956c/src/wasm/wasm-code-manager.h

Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Jan 25 2018

ClusterFuzz has detected this issue as fixed in range 531678:531681.

Detailed report: https://clusterfuzz.com/testcase?key=5406410577018880

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 8
Crash Address: 0x7fb62488df38
Crash State:
  v8::internal::wasm::NativeModule::NativeModule
  v8::internal::wasm::WasmCodeManager::NewNativeModule
  v8::internal::wasm::WasmCodeManager::NewNativeModule
  
Sanitizer: thread (TSAN)

Fixed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=531678:531681

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5406410577018880

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jan 25 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5406410577018880 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment