New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801846 link

Starred by 2 users
Status: Fixed
Owner:
guidou@chromium.org
Closed: Jan 2018
Cc:
a...@chromium.org
guidou@chromium.org
pbos@chromium.org
m...@chromium.org
robliao@chromium.org
█ olka@chromium.org
steimel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

"Playing sound" alert stuck turned on for silent tab

Project Member Reported by a...@chromium.org, Jan 13 2018 
Version 65.0.3315.3 (Official Build) dev (64-bit)

This repro is 100% for me, but it's on a Google internal page.

1. Go to https://sites.google.com/a/google.com/scaleability/Home/performances/archive
2. Click the first link, the one from the Fall 2016 concert. This will pull up a Drive video.
3. Click the play button.
> Notice you get the little "playing sound" icon in the tab.
4. While the video is playing, click the back button.
> We navigate back to the previous page but the indicator never goes away even though the tab is silent.

Assigning to a media peep.

Comment 1 by mlamouri@chromium.org, Jan 15 2018

Cc: steimel@chromium.org
+steimel@ given the timing with mute setting.

Comment 2 by dalecur...@chromium.org, Jan 16 2018

Cc: -steimel@chromium.org m...@chromium.org
Owner: steimel@chromium.org
=>ux folk; nothing has changed in how that code works AFAIK.

Comment 3 by dalecur...@chromium.org, Jan 16 2018

Cc: olka@chromium.org
+olka just in case though.

Comment 4 by olka@chromium.org, Jan 16 2018

Cc: guidou@chromium.org
+guidou who did some refactoring around play state notifications

Comment 5 by guidou@chromium.org, Jan 17 2018

Owner: guidou@chromium.org
The issue is caused by the refactoring. I'll look into it.

Comment 6 by guidou@chromium.org, Jan 17 2018

Labels: M-65

Comment 7 by guidou@chromium.org, Jan 17 2018

Components: -Internals>Media>UI Blink>WebRTC>Audio

Comment 8 by steimel@chromium.org, Jan 17 2018

Cc: steimel@chromium.org

Comment 9 by guidou@chromium.org, Jan 17 2018 

The issue is not specific to Mac, but to official builds.
I was able to repro on an official Linux build.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4df6e26771b5f45a6107f7cf81c7c6a4fde9bf

commit bf4df6e26771b5f45a6107f7cf81c7c6a4fde9bf
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu Jan 18 12:49:50 2018

Stop monitoring audio streams from a deleted frame.

Before this CL, it was possible that the speaker tab indicator was not
updated correctly upon removal of frames containing audio streams.

Bug:  801846 
Change-Id: If92a26edbfac93ae673b3f5a0207fcb51098effb
Reviewed-on: https://chromium-review.googlesource.com/873350
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530127}
[modify] https://crrev.com/bf4df6e26771b5f45a6107f7cf81c7c6a4fde9bf/content/browser/media/audio_stream_monitor.cc
[modify] https://crrev.com/bf4df6e26771b5f45a6107f7cf81c7c6a4fde9bf/content/browser/media/audio_stream_monitor.h
[modify] https://crrev.com/bf4df6e26771b5f45a6107f7cf81c7c6a4fde9bf/content/browser/media/audio_stream_monitor_unittest.cc

Comment 11 by guidou@chromium.org, Jan 18 2018

Status: Fixed (was: Assigned)

Comment 12 by guidou@chromium.org, Jan 24 2018

Cc: robliao@chromium.org pbos@chromium.org
 Issue 805601  has been merged into this issue.
►

Sign in to add a comment